Conversation
Owner
Author
|
TODO: add tests to ensure results are unchanged between numpy with "unique_junctions=False" and dask. |
3 tasks
Collaborator
|
TODO:
|
Collaborator
|
I've got some bad news about the tests @jni - there's a problem besides the test environment dependencies |
Owner
Author
|
This is the line that install things when running tests: skan/.github/workflows/test.yml Line 53 in 97a217d So dask needs to be added to: Line 65 in 97a217d |
Collaborator
|
Hmm, would have thought that was being handled by the Thanks for checking into it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @GenevieveBuckley
Description
Type of change
References
How has this been tested?
Final checklist:
trans.to make them localizable.For more information see our translations guide.