Conversation
This reverts commit 290838c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merging. This exists to get a CI signal on
aarch64-unknown-linux-gnu/gcc (Release), the only job wheretest_gdb.test_jitcurrently fails on python#157766.It is the PR branch with
290838c1ad5 Check _GUARD_BUILTINS_IS_CANONICAL once per framereverted, sitting on the same merge ofmainas the current PR head, so the only difference from the red tree is that commit.Evidence so far
290838c1ad5(PR only, base6dad8b88cc3)Merge f8286174954 into e9ae46f02b0Merge 290838c1ad5 into a3e389d46d9Merge e4f54de237b(PR + main)The fork builds the pushed commit directly; the upstream PR jobs build a merge with
main. The exact commit that fails upstream passes on the fork, so the dedup commit alone does not reproduce it — the red trees all containmaincommits that the green trees do not (e9ae46f02b0..a3e389d46d9, nine commits, none touching the JIT).Locally the commit also does not change what gets traced: the sample's full executor graph (root trace, cold exit, stitched side-exit trace) is byte-identical across the PR base,
f8286174954and290838c1ad5, on both the tier-two interpreter and a native-JIT build, and contains no_GUARD_BUILTINS_IS_CANONICALat all.sizeof(_Py_UOpsAbstractFrame)is unchanged at 72 (the newboollands in existing padding), and a fullnmdiff of the two binaries shows one symbol moved, by two bytes.What each outcome means
mainside, and the underlying fragility is in the gdb JIT unwind info.Python/jit_unwind.c:311registers a single CFI rule for every PC in a JIT region (CFA = x29+16), valid only in the executor's steady state.