Repository navigation
Conversation
Add case-insensitive WebP support to GetUtils.isImage and String.isImageFileName. Cover capitalization, file paths, existing formats and unsupported suffixes with regression tests; document both public APIs. Fixes jonataslaw#3430
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetUtils.isImage('photo.webp')currently returnsfalse, although WebP is an image format. Add.webpto the existing case-insensitive suffix checks;String.isImageFileNameinherits the support through its existing delegation.Add regression tests for all 16 capitalization combinations of
webp, file names and paths, existing image formats, and strings without a supported final extension. Update the API documentation and English README with both public entry points.Fixes #3430
Validation
Tested locally with Flutter 3.47.5 and Dart 3.13.4.
flutter test --reporter expanded— 228 passed.git diff --check: passed.lib/get_connect/http/src/http.dart:235(unawaited_return_in_try_block).Pre-launch Checklist
Coverage collection was attempted but stalled during test startup in this environment and was interrupted. The standard full suite completed successfully; no coverage percentage is claimed.