Skip to content

test: centralize Varnish runtime diagnostics in E2E harness - #136

Merged
jonbaldie merged 1 commit into
masterfrom
fleet/ci-52a62331b424414b9ed39cae87e085a0-1-8376b8d2c5a1
Oct 7, 2026
Merged

jonbaldie merged 1 commit into
masterfrom
fleet/ci-52a62331b424414b9ed39cae87e085a0-1-8376b8d2c5a1

Conversation

@jonbaldie

Copy link
Copy Markdown
Owner

Closes #128

Summary

  • Add a shared Varnish-container lookup for PURGE requests and VSL assertions.
  • Add assert_no_vcl_errors <context> [pattern] and refactor the unsafe-location scenario to use it.
  • Dump Varnish runtime VSL diagnostics alongside Compose logs when startup, readiness, or assertions fail, without changing the fixture exit status.

Verification

  • Passed make test-compose-fixture-lifecycle, make test-purge, make test-hostile-unsafe-location, and make test-hostile-unsafe-location-canary.
  • Temporarily removed the referenced-URI whitespace encoding; the unsafe-location test failed through assert_no_vcl_errors and showed the ban(): Expected && between conditions VSL record.
  • The required local gate COMPOSE_PARALLEL_LIMIT=1 make -j1 test test-e2e-hard stopped at the existing test-smoke-runtime-interface target: its 5-second startup probe killed a docker run that took about 10 seconds to exit after printing the expected invalid-listen error. The gate did not reach the harness tests.

Add a shared Varnish container lookup, expose assert_no_vcl_errors to scenario assertions, and include VSL records when Compose fixtures fail. The unsafe-location scenario uses the no-pattern assertion because its VSL contains no other VCL_Error records.

Closes #128
@jonbaldie
jonbaldie merged commit 2374ec1 into master Oct 7, 2026
2 checks passed
@jonbaldie
jonbaldie deleted the fleet/ci-52a62331b424414b9ed39cae87e085a0-1-8376b8d2c5a1 branch October 7, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepen test harness with VCL runtime error and log diagnostics interface

1 participant