Repository navigation
Share varnishd arguments between preflight and startup - #159
Merged
Merged
Conversation
The duplicated check invocation omitted -a, so invalid listen hosts passed preflight. Build both invocations through varnishd_args and cover DNS/numeric host failures with real containers. Account for compile mode binding sockets in the runtime test and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #157. The duplicated check list omitted the listen argument. Preserve shell validation and override behavior; document compile-mode socket binding and network/DNS requirements.
Evidence
bash test/e2e/assert-config-check.shfailed:/start.sh --check should reject listen host nohost.invalid:80 with resolution diagnostics.After: both modes reject
nohost.invalid:80and999.1.1.1:80withGot no socket(s).make test-smoke-runtime-interfacepassed, including real HTTP requests and command overrides.COMPOSE_PARALLEL_LIMIT=1 make -j1 test test-e2e-hardpassed.Merge Danger
Door: two-way
Blast Radius: preflight
Checks now resolve and bind the configured listener, as startup already does. Run preflight in the deployment network, separately from an instance using that port.