Repository navigation
Fix backend checks overwriting live VCL - #160
Merged
Merged
Conversation
Checks previously rendered into live backend.vcl before compilation, leaving failed candidates behind and poisoning restart. Compile isolated candidates and publish only after successful startup validation; preserve no-override configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep existing backends when no overrides are supplied. The renderer alone owns backend defaults. Replace check-time file-write assertions with active VCL evidence and real-container isolation/restart coverage.
Fixes #158.
Evidence
nohost.invalidchecks exited 2 and changed the live backend on two consecutive runs. The new regression failed withFAIL: check/start overwrote live VCL.After: Successful/failed checks and failed startup preserve every live VCL hash; concurrent checks clean candidates; HTTP remains available after failed check and restart. An unresolvable candidate produces VCC diagnostics, proving compilation uses the candidate rather than the live backend.
make test-vcl-compileandmake test-smoke-runtime-interfaceagainst the built image.COMPOSE_PARALLEL_LIMIT=1 make -j1 test test-e2e-hardserially, including real HTTP backend-adapter scenarios.Root cause: startup rendered directly into the live backend before reaching compilation or the check/start branch. Compilation failure therefore left an invalid persistent backend behind.
Merge Danger
Door: two-way
Blast Radius: startup
Embedded VCL now resolves its backend through the VCL include path. Mounted/custom VCL without backend overrides retains its current behavior. Listen binding during checks is unchanged. No cache-policy changes.