Repository navigation
fix(words): wire sort filter to URL params and API - #15
Merged
Merged
Conversation
Sort select was calling an unconnected prop callback — changes had no effect. Now reads/writes ?sort= URL param (consistent with ?category=) and passes it through useWords to the API. Removed newest/oldest options as they have no meaningful value in a dictionary context.
Updates useWords signature to include category and sort, adds note on reading params from URL state only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
docs/api-integration.md—useWordshook documenta los 4 parámetros (page,search,category,sort) y la regla de leerlos siempre desde URL paramsFixed
?sort=and propagated throughuseWordsto the APIRemoved
created_atordering has no meaningful value for end users browsing technical terms