feat(admin): keep labels in client and exporter output - #1044
Merged
Conversation
Labels are what an exporter is selected by and how clients are grouped, but from_dict rebuilt the metadata without them, so they were absent from `jmp admin get client|exporter -o json|yaml` even though the cluster had them. Anything reading that output - a UI listing a namespace, a script grouping exporters - had to fall back to kubectl for a field the command was already fetching. Assisted-by: Claude Signed-off-by: Kirk Brauer <kirkebrauer@gmail.com>
kirkbrauer
added
bug
Contributor
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bennyz
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jmp admin get client|exporter -o json|yamlrebuilt each object's metadata without its labels, so the field an exporter is selected by was missing from output the command had already fetched it in. Anything grouping or filtering exporters had to fall back to kubectl.Touches the same four files as #1045, so whichever merges second needs a trivial rebase.