Repository navigation
fix(submit): compact missing-client and active-time preservation warnings - #1596
Open
azestkingscrown wants to merge 1 commit into
Open
azestkingscrown wants to merge 1 commit into
azestkingscrown wants to merge 1 commit into
Conversation
…ings Extend submit warning compaction to group disappeared-client warnings per client and active-time warnings across days when 4 or more occur, preserving all dates and values.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the submit warning compaction introduced in #1581 to recognize and group missing-client (
Preserved {client} because it disappeared from this same-device resubmit; kept {kept} tokens.) and active-time (Preserved {stored}ms active time because this same-device resubmit reported only {incoming}ms.) preservation warnings alongside daily token decrease warnings.date: keptpairs.date: stored -> incomingpairs.Closes #1593
Evidence
crates/tokscale-cli/src/submission_warnings.rsverify compaction for disappeared clients, active-time decreases, short groups (< 4), invalid dates/values, and mixed warning lists preserving relative order.test_submit_compacts_missing_client_and_active_time_preservation_warningsincrates/tokscale-cli/tests/cli_tests.rstests synthetic HTTP submit response containing mixed warnings.cargo fmt --checkpasses.cargo clippy --locked -p tokscale-cli --all-features --all-targets -- -D warningspasses without warnings.cargo test -p tokscale-cli --bin tokscalepasses (1,764 passed, 1 ignored).TZ=UTC cargo test -p tokscale-cli --test cli_testspasses (221 passed).Summary by cubic
Extends submit warning compaction to also group missing-client and active-time preservation warnings alongside daily token decreases. Closes #1593.
When 4 or more warnings of the same kind occur, they're now compressed into a single heading with
date: keptordate: stored -> incomingdetails. Groups under 4 items and unrecognized messages are still printed verbatim. All dates, token counts, and millisecond values are preserved; server-side accounting, high-water mark protection, and merge logic are untouched.Written for commit 962d18f. Summary will update on new commits.