Skip to content

If syncTask requeued it would stop syncing rest of the backups - #1789

Open
burmanm wants to merge 2 commits into
k8ssandra:mainfrom
burmanm:fix_medusa_task_sync_1788
Open

burmanm wants to merge 2 commits into
k8ssandra:mainfrom
burmanm:fix_medusa_task_sync_1788

Conversation

@burmanm

@burmanm burmanm commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What this PR does:
Allows requeued sync task to continue instead of relying on the StartTime != 0 to mark finish rule.

Which issue(s) this PR fixes:
Fixes #1788

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm
burmanm requested a review from a team as a code owner September 10, 2026 13:03
@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.12%. Comparing base (7198039) to head (ab51fe8).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
controllers/medusa/medusatask_controller.go 71.42% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1789      +/-   ##
==========================================
+ Coverage   50.98%   58.12%   +7.13%     
==========================================
  Files         125      127       +2     
  Lines       13389     9772    -3617     
==========================================
- Hits         6827     5680    -1147     
+ Misses       5984     4092    -1892     
+ Partials      578        0     -578     
Files with missing lines Coverage Δ
controllers/medusa/medusatask_controller.go 73.83% <71.42%> (+25.98%) ⬆️

... and 119 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Momotoculteur

Copy link
Copy Markdown

Hello @burmanm
Thanks for this PR, i would like to know if there is any chance to have that fix deploy soon ?

@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Medusa backup sync operation returns only one backup per run

3 participants