Skip to content

fix: treat a cancelled configcheck as an error, not a passing check - #285

Merged
aa1ex merged 1 commit into
kaasops:mainfrom
aa1ex:fix/configcheck-cancel-is-not-success
Aug 20, 2026
Merged

fix: treat a cancelled configcheck as an error, not a passing check#285
aa1ex merged 1 commit into
kaasops:mainfrom
aa1ex:fix/configcheck-cancel-is-not-success

Conversation

@aa1ex

@aa1ex aa1ex commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Problem

While waiting for a configcheck result, a cancelled context is reported as no error at all. The pipeline reconciler reads that as a passing check and writes a success status, so a config that was never validated is published as validated.

Fix

Return the cancellation as an error instead. A check interrupted by a shutdown now ends with an error in the log rather than a silent pass.

Verification

A unit test cancels the context while the check is waiting and requires an error carrying context.Canceled; it was checked by putting the old return "", nil back and watching the test fail.

Signed-off-by: Aleksandr Aleksandrov <aaleksandrov.cy@gmail.com>
@aa1ex
aa1ex force-pushed the fix/configcheck-cancel-is-not-success branch from 6179b7b to 1d14a63 Compare August 20, 2026 20:15
@aa1ex
aa1ex marked this pull request as ready for review August 20, 2026 21:15
@aa1ex
aa1ex merged commit 579ce05 into kaasops:main Aug 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant