Fix array validation, length calculation, and compiler diagnostics - #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several compiler correctness issues involving array encoding, comparisons, and ambiguous declarations.
Bug Fixes
Reject malformed dynamic-array entrypoint payloads whose encoded length is not divisible by the element width.
Correct
.lengthfor derived arrays so it returns the element count instead of the encoded byte count.Report a compiler error when an entrypoint parameter conflicts with a contract field instead of panicking internally.
Reject duplicate entrypoint and helper-function names instead of silently resolving them inconsistently.