tests updated - #137
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61554d3ec5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --plugin @rollup/plugin-node-resolve \ | ||
| --name "__BUFFER__" | \ | ||
| perl -pe 's#^var __BUFFER__#const {Buffer}#' > $@ | ||
| --banner "const {Buffer} = " \ |
There was a problem hiding this comment.
When make -C browser test builds tests/buffer.shim.js, the CommonJS plugin exposes the exports from buffer/index.js, but this command no longer supplies --name. Rollup documents output.name as necessary for IIFE/UMD bundles that export values, so generation fails before the banner can destructure Buffer, breaking the Browser CI workflow; retain an output name and adapt the generated assignment instead of replacing it solely with a banner.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
🔵 Needs a closer look
The browser/Makefile bundling rewrite relies on non-trivial Rollup semantics and is not exercised by this PR's CI (Browser CI runs only on push to main), so its correctness cannot be fully verified automatically.
Pull request overview
This PR performs routine maintenance on the build/lint tooling and bumps versions. It simplifies the browser test bundling to use native Rollup output options instead of perl post-processing, switches jshint to lint the whole repo tree via a new .jshintignore, and bumps the package version and the msgpackr benchmark dependency.
Changes:
- Bump
versionto0.2.2and themsgpackrdevDependency to^2.1.0. - Replace the
perl -pepost-processing of Rollup output with native Rollup flags (--globals,--no-makeAbsoluteExternalsRelative,--banner,--file) inbrowser/Makefile. - Replace the explicit
HINTSfile list withjshint . --extra-ext .jsonplus a new.jshintignoreexcluding.github/,browser/,dist/,node_modules/.
File summaries
| File | Description |
|---|---|
| package.json | Version bump to 0.2.2 and msgpackr devDependency bump to ^2.1.0 (both valid). |
| Makefile | Drops HINTS variable and lints the whole repo with jshint . --extra-ext .json; scope effectively adds only the ES3-safe global.js. |
| browser/Makefile | Rewrites Rollup invocations to use native options instead of perl; buffer build now relies on --banner "const {Buffer} = " with an unnamed IIFE. |
| .jshintignore | New ignore file so jshint . skips generated/non-ES3 sources under .github/, browser/, dist/, node_modules/. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
No description provided.