Skip to content

chore: add contributors to json file - #845

Open
Meng-Heng wants to merge 1 commit into
masterfrom
chore/add-contributors-json
Open

Meng-Heng wants to merge 1 commit into
masterfrom
chore/add-contributors-json

Conversation

@Meng-Heng

@Meng-Heng Meng-Heng commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

@mcdurdin, will this be push automatically into /keyman.com/_content/about/team/index.md that we use in our blogs?

Test-bot: skip

@keymanapp-test-bot

keymanapp-test-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot Bot added this to the B19S3 milestone Oct 6, 2026
@github-actions github-actions Bot added the chore label Oct 6, 2026
@Meng-Heng
Meng-Heng requested a review from mcdurdin October 6, 2026 02:45

@mcdurdin mcdurdin left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcdurdin, will this be push automatically into /keyman.com/_content/about/team/index.md that we use in our blogs?

Yes, when the contributor report is run, it will pick up this new data automatically

Comment on lines +55 to +56
{ "level": "contributor", "handle": "Facundo Jaureguibehere", "url": "https://github.com/facundojaureguibehere", "pr": "keymanapp/keyboards#4119" },
{ "level": "contributor", "handle": "Manuel", "url": "https://github.com/MLocria", "pr": "keymanapp/keyboards#4119" }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For GitHub handles, we only need the PR# and the actual GitHub handle, not their real name. (Currently, we don't support looking up their avatar image when we reference them here; that would be a separate project)

Suggested change
{ "level": "contributor", "handle": "Facundo Jaureguibehere", "url": "https://github.com/facundojaureguibehere", "pr": "keymanapp/keyboards#4119" },
{ "level": "contributor", "handle": "Manuel", "url": "https://github.com/MLocria", "pr": "keymanapp/keyboards#4119" }
{ "level": "contributor", "handle": "facundojaureguibehere", "pr": "keymanapp/keyboards#4119" },
{ "level": "contributor", "handle": "MLocria", "pr": "keymanapp/keyboards#4119" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants