Skip to content

fix: set correct version for /downloads/releases pages #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcdurdin merged 1 commit into from
Oct 6, 2026
Merged

fix: set correct version for /downloads/releases pages #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion _content/downloads/releases/_version_downloads.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ function array_key_first(array $arr) {
}

// note: we currently ignore the tier parameter
$versions = @json_decode(Util::call_downloads_keyman_com("/api/version/2.0?targetVersion=$version", 'downloads.keyman.com-api_version_2.0.json'));

$versions = DownloadUI::setVersion($version);

if(empty($versions->android))
$tier = 'unknown';
Expand Down
56 changes: 36 additions & 20 deletions _includes/2020/DownloadUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,14 @@
use Keyman\Site\com\keyman\Util;
Locale::definePageScope('LOCALE_DOWNLOADS', 'downloads');

global $versions;
$versions = @json_decode(Util::call_downloads_keyman_com('/api/version/2.0', 'downloads.keyman.com-api_version_2.0.json'));

class DownloadUI {
private static $versions;

public static function setVersion($version) {
DownloadUI::$versions = @json_decode(Util::call_downloads_keyman_com("/api/version/2.0?targetVersion=$version", 'downloads.keyman.com-api_version_2.0.json'));
return DownloadUI::$versions;
}

private static function formatSizeUnits($bytes) {
if ($bytes >= 1073741824) {
$bytes = number_format($bytes / 1073741824, 2) . ' GB';
Expand All @@ -30,7 +34,6 @@ private static function formatSizeUnits($bytes) {
}

private static function filenamePatterns($target, $tier) {
global $versions;
switch($target) {
case 'android': return 'keyman-$version.apk';
case 'android-engine': return 'keyman-engine-android-$version.zip';
Expand Down Expand Up @@ -89,23 +92,35 @@ public static function downloadSection($platform, $tiers = '', $target = '') {
}
}

private static function initVersions() {
if(empty(DownloadUI::$versions)) {
DownloadUI::$versions = @json_decode(Util::call_downloads_keyman_com('/api/version/2.0', 'downloads.keyman.com-api_version_2.0.json'));
if(empty(DownloadUI::$versions)) {
return false;
}
}
return true;
}

private static function downloadLinks($platform, $tier, $filepatterns) {
global $versions;
if(!DownloadUI::initVersions()) {
return false;
}
$product = DownloadUI::productName($platform);
echo sprintf("<h3>%s</h3>\n<ul>\n", ucFirst(_m_Downloads($tier)));
if(!empty($versions->$platform->$tier)) {
if(!empty(DownloadUI::$versions->$platform->$tier)) {
if(!is_array($filepatterns)) $filepatterns = array($filepatterns);
foreach($filepatterns as $filepattern) {
$file = str_replace('$version', $versions->$platform->$tier->version, $filepattern);
$file = str_replace('$version', DownloadUI::$versions->$platform->$tier->version, $filepattern);
$file = str_replace('$tier', $tier, $file);

if(!empty($versions->$platform->$tier->files->$file)) {
$fileData = $versions->$platform->$tier->files->$file;
if(!empty(DownloadUI::$versions->$platform->$tier->files->$file)) {
$fileData = DownloadUI::$versions->$platform->$tier->files->$file;
$fileSize = DownloadUI::formatSizeUnits($fileData->size);
echo sprintf("<li><a href='%s/%s/%s/%s/%s'>%s %s</a> %s</li>\n",
KeymanHosts::Instance()->downloads_keyman_com ,
$platform, $tier,
$versions->$platform->$tier->version,
DownloadUI::$versions->$platform->$tier->version,
$file, $file, $tier,
_m_Downloads('released_date_size', $fileData->date, $fileSize));
}
Expand All @@ -117,9 +132,9 @@ private static function downloadLinks($platform, $tier, $filepatterns) {
}

public static function downloadLargeCTA($platform, $tier) {
global $versions;

if(empty($versions)) return false;
if(!DownloadUI::initVersions()) {
return false;
}

$found = false;

Expand All @@ -128,26 +143,27 @@ public static function downloadLargeCTA($platform, $tier) {
// CTA only supports the first download (which will typically be the right one?)
if(!is_array($filepatterns)) $filepatterns = [$filepatterns];
foreach($filepatterns as $filepattern) {
$file = str_replace('$version', $versions->$platform->$tier->version, $filepattern);
$file = str_replace('$version', DownloadUI::$versions->$platform->$tier->version, $filepattern);
$file = str_replace('$tier', $tier, $file);

if(empty($versions->$platform->$tier->files->$file)) {
if(empty(DownloadUI::$versions->$platform->$tier->files->$file)) {
continue;
}

$found = true;

$fileData = $versions->$platform->$tier->files->$file;
$fileData = DownloadUI::$versions->$platform->$tier->files->$file;
$fileSize = DownloadUI::formatSizeUnits($fileData->size);
$host = KeymanHosts::Instance()->downloads_keyman_com;
$downloadSiteUrl = "$host/$platform/$tier/{$versions->$platform->$tier->version}/$file";
$downloadUrl = htmlentities("/go/app/download/$platform/{$versions->$platform->$tier->version}/$tier?url=".
$downloadSiteUrl = "$host/$platform/$tier/" . DownloadUI::$versions->$platform->$tier->version . "/$file";
$downloadUrl = htmlentities("/go/app/download/$platform/" . DownloadUI::$versions->$platform->$tier->version . "/$tier?url=".
rawurlencode($downloadSiteUrl));

$v = DownloadUI::$versions->$platform->$tier->version;
echo <<<END
<div class="download-cta-big selected" id="cta-big-Windows" data-url='$downloadUrl' data-version='{$versions->$platform->$tier->version}'>
<div class="download-cta-big selected" id="cta-big-Windows" data-url='$downloadUrl' data-version='{$v}'>
<div class="download-stable-email">
<h3>$title {$versions->$platform->$tier->version}</h3>
<h3>$title {$v}</h3>
<p>Released: {$fileData->date}</p>
<p>Size: $fileSize</p>
</div>
Expand Down
Loading