[Feature]: Delete oldest recording when we have more than X files

[spider703]

Checklist

• I have searched existing issues and discussions and this is not a duplicate.
• I am suggesting a new feature or enhancement for ShizuCallRecorder itself, NOT for Shizuku or another app.
• I have read the project README.md and CONTRIBUTING.md.
• I have read the application docs.

Is your feature request related to a problem? Please describe.

Great app, has access to internal memory, can you add a feature in the next update to delete records after a certain number of 60 days?

Describe the solution you'd like

menu button

Describe alternatives you've considered

No response

Additional context / Mockups

No response

[kitsumed]

Duplicate of #14.

I'm not purely against the idea of deleting old files. The main issue with a day-based approach is that we would need either a daily scheduled task (not sure if that's possible) or a process running in the background to enforce a true "60 days" retention period.

I could look into storing X numbers of files and deleting the oldest ones when the limit is reached. That check could run at the end of calls or when the application starts. I'm not sure yet how well that approach would work too. I'm gonna keep this issue open for now

[spider703]

The records file is written in the year/month/day format, and this can be used as a starting point. Here is the starting value, add 60 days to it, and then the file is deleted.

[kitsumed]

The records file is written in the year/month/day format, and this can be used as a starting point. Here is the starting value, add 60 days to it, and then the file is deleted.

This would only work if the user keep the date it its file format. Next release will bring a feature that allow users to change the file name formats. Parsing files with date would be possible since we could base ourself on the user defined template for the name, but if an user decide to fully strip-out the date parameter this would no longer works.

[spider703]

In this case, it will be necessary for a notification to appear that if the user changes the date format in the entry, then automatic deletion by time will not work.
I also noticed that when a number is added to the contact list, it is recorded as a phone number in the entries, not as a contact from the phone book.
google translate

[kitsumed]

I also noticed that when a number is added to the contact list, it is recorded as a phone number in the entries, not as a contact from the phone book.

Yes you are right, This could be an issue if someone update their contact numbers. I didn't catch on this when refractoring the code. If you could make a separate issue for this, I will look into how this could be fixed.

[kitsumed]

I'm still thinking about it, but I'm struggling to find the motivation to implement it/say OK to a PR. If our app also handled displaying and managing the list of recordings, it would make sense to me. However, since ShizuCallRecorder goal is only to perform the recording itself, it feels like adding a feature that should be handled by another app. In the future, that would also create additional maintenance burden.

For example, I do recommend BCR-GUI to users to have a UI with the list of recording. BCR-GUI also have a issue about adding this feature: nicorac/bcr-gui#233.

On the other side, BCR-GUI has a valid point, their logic would only run when the user open the app, while we could do it every time a call end or start (since we get woken up by Android OS).