Repository navigation
stale landing plans do not block bundle sync (knit) - #235
Merged
marc-merino merged 2 commits intoOct 1, 2026
Merged
Conversation
A landing plan generated before the bundle's latest commits pins old heads, and the sync remote refuses it as a stale bundle fingerprint. Uploading it failed the whole bundle sync with an HTTP 422 that did not mention the plan, even though the artifact had already been pushed. Sync now keeps such a plan local and says how to regenerate it, and a landing plan upload that still fails is reported as a warning after the artifact and history sync instead of as a skipped sync. Knit-Group: kg_20261001_6de23a Knit-Bundle: stale-landing-plans-do-not-block-bundle-sync
Knit-Group: kg_20261001_a56443 Knit-Bundle: stale-landing-plans-do-not-block-bundle-sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
View bundle
This PR is part of Knit bundle
stale-landing-plans-do-not-block-bundle-sync.See the other review objects in this bundle:
knit: stale landing plans do not block bundle sync (knit) #235 (this PR)Bundle id:
stale-landing-plans-do-not-block-bundle-syncBundle title: stale landing plans do not block bundle sync