Repository navigation
Wait for forge mergeability before landing (knit) - #256
Merged
marc-merino merged 2 commits intoOct 12, 2026
Merged
Conversation
Forges compute mergeability asynchronously. Right after a review opens or its base moves, Forgejo reports it as not mergeable and GitHub and GitLab report it as still computing, and knit land apply took that first answer as a conflict. Landing now re-reads a provisional answer with bounded backoff before deciding, waits on explicit computing states, and still merges a mergeable review on the first read. knit land check shows computing instead of conflict. Knit-Group: kg_20261012_a8e641 Knit-Bundle: wait-for-forge-mergeability-before-landing
Both landings use the same project, so each test gets its own temp directory for the landing ownership locks, set through TMP and TEMP as well as TMPDIR because Windows ignores TMPDIR. Knit-Group: kg_20261012_430d3b Knit-Bundle: wait-for-forge-mergeability-before-landing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
View bundle
This PR is part of Knit bundle
wait-for-forge-mergeability-before-landing.See the other review objects in this bundle:
knit: Wait for forge mergeability before landing (knit) #256 (this PR)Bundle id:
wait-for-forge-mergeability-before-landingBundle title: Wait for forge mergeability before landing