Repository navigation
Reclaim landing locks left by a process that exited (knit) - #269
Merged
marc-merino merged 2 commits intoNov 7, 2026
Merged
Conversation
A landing killed before it returned (SIGKILL, a closed terminal) left one lock file per landing resource, holding only its PID. Every later apply and resume stopped at the first of them, and the only way on was to remove the files by hand. Each lock now names an owner record that lists every step process group the owner started. When the owner has exited and none of those groups is still running, apply and resume take the lock over and say so. A lock that cannot be verified (an earlier release's bare PID, or a crash while starting a step) still blocks, and the error names `knit land unlock --confirm-quiescent`, which releases all of them in one go once the operator has checked. A lock held by a running process is never released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Knit-Group: kg_20261107_ab2e23 Knit-Bundle: reclaim-landing-locks-left-by-a-process-that-exited
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Knit-Group: kg_20261107_9a1a17 Knit-Bundle: reclaim-landing-locks-left-by-a-process-that-exited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
View bundle
This PR is part of Knit bundle
reclaim-landing-locks-left-by-a-process-that-exited.See the other review objects in this bundle:
knit: Reclaim landing locks left by a process that exited (knit) #269 (this PR)Bundle id:
reclaim-landing-locks-left-by-a-process-that-exitedBundle title: Reclaim landing locks left by a process that exited