Repository navigation
stdlib: Fix maximum # of digits for 32-bit integers - #133
Merged
Merged
Conversation
Contributor
Author
|
@MarlenaPanagiotakou brought to my attention that the 64-bit case is also wrong (64-bit integers require up to 19 digits for signed integers, or 20 digits for unsigned integers, not 18). In which case, I'd recommend just allocating 20 bytes in case there's ever a language with unsigned integers in this class. |
Owner
|
Thanks @wheremyfoodat @MarlenaPanagiotakou for finding and fixing this problem. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum 32-bit integer is:
In both cases, the number is obviously 10 digits instead of 9. This error would randomly cause memory corruptions when running the rand_gen.pcl program, which prints large numbers given the .input file in this repo.
In my case, the memory corruption would cause a segfault on MacOS, despite going unnoticed on Linux