[immanuwell]

Purpose of this PR

A 55 character ScheduledSparkApplication name is accepted, but even the shortest minutes suffix creates a 64 character run name.
The child webhook rejects it, so the schedule never starts.
so this is still reachable after #2827

Related to #2602.

Proposed changes:

• Reuse the existing hash and truncation helper for scheduled run names
• Keep names unchanged when they already fit
• Test the real parent admission and child creation path, plus collision safety

Reproduction

1. Create a schedule with metadata.name set to 55 lowercase letters
2. Set timestamp precision to minutes
3. Wait for a run. The parent exists, but child creation fails with must be no more than 63 characters

Change Category

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Rationale

Only names that already fail are changed. Working names stay byte for byte the same, so yeah this is pretty contained.

Checklist

• I have conducted a self-review of my own code.
• Documentation is not needed for this behavior fix.
• I have added tests that prove my changes are effective.
• Existing unit tests pass locally with my changes.

Additional Notes

go test ./..., go vet ./..., and make go-lint pass locally.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vara-bonthu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

🎉 Welcome to the Kubeflow Spark Operator! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

• If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
• Our team will review your PR soon!

Join the community:

• Slack: Join our #kubeflow-spark-on-kubernetes Slack channel.

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

[tariq-hasan]

Hi @immanuwell! I have added a few comments.

[tariq-hasan]

/assign

[tariq-hasan]

@immanuwell Please address the review comments so we can move forward with this PR.

[immanuwell]

@tariq-hasan everything is addressed, please take a look

[tariq-hasan]

Thanks @immanuwell!
/lgtm

[tariq-hasan]

/cc @nabuskey