Repository navigation
Conversation
QueueNamePrefix truncates cluster names longer than 75 characters, but `kops delete cluster` listed queues by the untruncated cluster name, so the node-termination-handler queue of a long-named cluster was never found and leaked. Move the helper to awsup, next to GetClusterName40, and use it in the model, the NTH addon template and the resource lister. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
kubernetes-prow
Bot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
area/provider/aws
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kops updatenames the NTH queue withQueueNamePrefix(clusterName)(periods replaced, truncated to 75 characters with a hash, since #17877).kops deletelisted queues by the untruncated prefix, so clusters with names over 75 characters leaked their queue. kubetest2-kops names clusterse2e-<job>.tests-kops-aws.k8s.io, so every kops AWS job with a name over 49 characters leaks one queue per run. The next run adopts the leaked queue, the janitor deletes it at 12 h, and NTH panics withAWS.SimpleQueueService.NonExistentQueue(e2e-ci-kubernetes-kops-al2023-aws-conformance-aws-cni, 2026-10-29); validation fails.One helper in
awsupfor all three callers. The SQS mock does real prefix matching and implementsDeleteQueue, which the lifecycle tests now reach. Affects release-1.34 and later.AI assisted with the triage and the patch.