Repository navigation
fix(e2e): retry the re-run lookup and pass inputs to the dispatch via env - #104
Merged
Merged
Conversation
… env
- Re-run lookup retries for up to 7.5 min. A re-run soon after the first
attempt can still miss the run, since the App token sees new runs late.
- Values used in the dispatch script move from inline ${{ }} to env, so a
workflow input cannot inject shell code into the step that holds GH_TOKEN.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Rotem Refael <rotem@armosec.io>
rotemamsa
added
the
ai-assisted
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Summary:
|
1 similar comment
|
Summary:
|
Naor-Armo
approved these changes
Oct 7, 2026
rotemamsa
added a commit
to kubescape/regolibrary
that referenced
this pull request
Oct 7, 2026
ci: pin kubescape-cli-e2e-tests to kubescape/workflows#104
armobot
pushed a commit
to kubescape/regolibrary-dev
that referenced
this pull request
Oct 7, 2026
Re-run lookup retries, and dispatch inputs are passed via env instead of inline expressions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Rotem Refael <rotem@armosec.io>
This was referenced Oct 7, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #103, from review comments on the matching caller PRs.
Changes
${{ inputs.* }}/${{ needs.* }}/${{ github.run_id }}are now passed throughenvand read as shell variables, so an input cannot inject shell code into the step that holdsGH_TOKEN. The pattern predates fix(e2e): get the E2E run ID from the dispatch response #103.Both
kubescape-cli-e2e-tests.yamlandincluster-comp-pr-merged.yaml. YAML parses; no${{ }}is left inside either dispatch script.AI-skills: armosec-shared-rules:docs_factcheck,high-confidence-review,superpowers:systematic-debugging