Repository navigation
ci: allow callers to set the Go test package timeout - #94
Merged
Merged
Conversation
Preserve the ten-minute default while allowing large race-enabled suites to select a larger bounded budget. Validate positive integer minutes and preserve race, coverage, and result artifacts. Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Summary:
|
1 similar comment
|
Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large race-enabled storage suites now exceed Go's default ten-minute package timeout; kubescape/storage#402 run 35097423818 was terminated while its crash-recovery test was still running after the mixed-corpus migration passed.
Add
TEST_TIMEOUT_MINUTESto the reusable Go test workflow and its incluster PR wrapper. The default remains 10 minutes; storage can opt into 30 without changing other callers. Both race and coverage runs receive a quoted-timeoutargument. Invalid values fail before Go executes, and existing diagnostics/artifacts remain intact.Validation: all 11 Python harness tests pass, including default/custom timeout, both test modes, invalid inputs, and wrapper forwarding.
git diff --checkpasses. Actionlint reports only the existing two undeclaredGH_PERSONAL_ACCESS_TOKENreferences.