fix: resolve ssh config per connection target - #254
Merged
Conversation
Add a per-host SshConnectionConfigResolver so exec, ping, upload, and download resolve AddressFamily, Compression, ServerAliveInterval, and ServerAliveCountMax against each target node instead of a once-per-dispatch fallback. Pass the same resolver into jump chains so each jump hop resolves against its own Host block, while preserving fixed-config compatibility for existing callers. Validated with cargo fmt, cargo test --lib executor::parallel::tests::connection_config_for_node_resolves_each_node_host_block, cargo test --lib ssh::tokio_client::connection_tests::test_connection_config_resolver, cargo test --lib jump::chain::tests::test_chain_resolves_connection_config_per_jump_host, cargo check --lib --tests, and cargo clippy --lib --tests -- -D warnings. Closes #249
inureyes
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve SSH connection settings per target host instead of once per dispatch, covering AddressFamily, Compression, ServerAliveInterval, and ServerAliveCountMax for exec, ping, upload, and download.
What changed
Test plan
Closes #249