Preserve submission credit when baseline admission is closed - #130
Open
camfairchild wants to merge 1 commit into
Open
camfairchild wants to merge 1 commit into
camfairchild wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A finalized submission arriving after its commissioned baseline closed received
baseline_closed_at_submissionas a candidate FAIL, leaving its evaluation credit consumed. Reject it before screening asexpired/NO_DECISIONand release its credit or cited payment in the same transaction, so the miner can resubmit against an open baseline.The dashboard submission details and miner report now explain: “This baseline closed before your submission. Your submission credit has been preserved.” They direct the miner to the current open baseline. Historical FAIL rows are not presented as having received a credit refund.
Consumer:
prepare_screen_queuein routed coordinator and synchronous-validator admission, plus dashboard details and miner reports. Casualty: the late-baselinemark_failedcall. Extract the existing closed-target credit/payment release transaction for reuse; keep the existing error code and cutoff boundaries. No historical data rewrite, new schema, GPU behavior change, or deployment.Validation:
Documentation: updated miner diagnostics with the no-charge rejection and exact message. Directory line ceilings reflect this change; the oversized intake file shrinks by 21 lines. Production +40/-29 (net +11), docs +5/-1, tests +45/-9, ratchet accounting +5/-5; total +95/-44 (net +51).