Skip to content

feat: Emit provider events from LaunchDarkly client status - #29

Merged
kinyoklion merged 1 commit into
mainfrom
devin/ruby-provider-events
Aug 21, 2026
Merged

feat: Emit provider events from LaunchDarkly client status#29
kinyoklion merged 1 commit into
mainfrom
devin/ruby-provider-events

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Aug 19, 2026

Copy link
Copy Markdown
Member

Forwards LaunchDarkly client status and flag change notifications to the OpenFeature SDK as provider events.

  • The provider now includes OpenFeature::SDK::Provider::EventEmitter and registers listeners on the LaunchDarkly data source status provider and flag tracker.
  • VALID emits PROVIDER_READY, INTERRUPTED emits PROVIDER_STALE, and OFF emits PROVIDER_ERROR with the GENERAL error code and the last error in the message.
  • OFF deliberately does not use PROVIDER_FATAL: the LaunchDarkly client can still evaluate its last known flag data, and a fatal state would make the OpenFeature SDK return call-site defaults instead.
  • Flag changes emit PROVIDER_CONFIGURATION_CHANGED with the changed flag key.
Implementation details

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Part of an audit of the LaunchDarkly OpenFeature providers against the current OpenFeature specification. Provider events (spec section 5) were not implemented here, so applications had no way to react to LaunchDarkly connection loss, recovery, or flag configuration changes through the OpenFeature API.

Describe the solution you've provided

Two small listener classes in Impl translate LaunchDarkly notifications into OpenFeature events, and the provider registers them when the client is constructed. EventEmitter#emit_event is a no-op until the OpenFeature SDK attaches its configuration to the provider, so events raised before the provider is set are safely dropped.

Describe alternatives you've considered

Mapping OFF to PROVIDER_FATAL — rejected for the reason above; this matches the Java provider and the corresponding fix being made in the Python provider. Emitting one event per changed flag with no payload — rejected in favor of including flags_changed so handlers can filter.

Testing

bundle exec rake (RSpec + RuboCop) on Ruby 3.4: 59 examples, 0 failures; 15 files inspected, no offenses. Ruby 3.4 was used because the gemspec requires >= 3.4.

@cursor review

Link to Devin session: https://app.devin.ai/sessions/0c452d209ec54b068ba120b4c92b8f6c
Requested by: @kinyoklion


Note

Overview
Implements OpenFeature provider events (spec section 5) so apps can react to LaunchDarkly connection state and flag updates through the OpenFeature API.

The Provider now includes OpenFeature::SDK::Provider::EventEmitter and registers two listeners when the LD client is constructed: on data_source_status_provider and flag_tracker.

Data source status maps to events: VALIDPROVIDER_READY, INTERRUPTEDPROVIDER_STALE (with message), OFFPROVIDER_ERROR with GENERAL and last error details in the message—not PROVIDER_FATAL, so evaluation can still use last-known flags. INITIALIZING emits nothing.

Flag changes emit PROVIDER_CONFIGURATION_CHANGED with flags_changed containing the changed key.

New Impl::DataSourceStatusListener and Impl::FlagChangeListener translate LD notifications into emit_event calls; specs cover each mapping.

Reviewed by Cursor Bugbot for commit dc2ae67. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion kinyoklion self-assigned this Aug 19, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot added the devin-pr PRs created by Devin label Aug 19, 2026
)
when ::LaunchDarkly::Interfaces::DataSource::Status::OFF
@provider.emit_event(
::OpenFeature::SDK::ProviderEvent::PROVIDER_ERROR,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside: We don't say fatal, because then OF short-circuits evaluations.

@kinyoklion
kinyoklion marked this pull request as ready for review August 19, 2026 16:56
@kinyoklion
kinyoklion requested a review from a team as a code owner August 19, 2026 16:56
@kinyoklion
kinyoklion merged commit 1b53b0c into main Aug 21, 2026
10 checks passed
@kinyoklion
kinyoklion deleted the devin/ruby-provider-events branch August 21, 2026 21:42
kinyoklion added a commit that referenced this pull request Aug 25, 2026
Adds a feature matrix to the README mirroring the OpenFeature Ruby SDK's
own feature table, so a reader can see at a glance what the provider
does and does not support.

- One row per OpenFeature SDK feature (providers, targeting, hooks,
logging, domains, eventing, shutdown, tracking, transaction context
propagation, extending), plus initialization and flag metadata.
- Every row is currently supported following the tracking, lifecycle,
eventing, wrapper, and flag metadata work; each note says how the
provider implements it, or that the OpenFeature SDK provides it with no
provider involvement.
- The legend keeps room for `⚠️`/`❌` so unsupported rows can state
whether the limitation is in the OpenFeature Ruby SDK or is a provider
gap.

<details>
<summary>Implementation details</summary>

**Requirements**

- [x] I have added test coverage for new or changed functionality
- [x] I have followed the repository's pull request submission
guidelines
- [x] I have validated my changes against all supported platform
versions

**Related issues**

Follow-up to the audit of LaunchDarkly's OpenFeature providers, which
produced #27, #28, #29, #30 and #31 in this repository.

**Describe the solution you've provided**

The matrix reuses the row set and legend of the [OpenFeature Ruby SDK
feature table](https://github.com/open-feature/ruby-sdk#-features) so
the two can be read side by side, and so the same format can be applied
to the other LaunchDarkly providers. Statements about eventing,
initialization, shutdown, tracking, and flag metadata were checked
against the current implementation in `lib/ldclient-openfeature`.

**Describe alternatives you've considered**

Writing a LaunchDarkly-specific row set instead of mirroring
OpenFeature's — rejected, since the point of the matrix is comparability
with the OpenFeature SDK table and with the other providers.

**Testing**

Documentation only; no code changes.

**Additional context**

Screenshots and a staging preview do not apply to a README change in a
server-side library.

</details>


Link to Devin session:
https://app.devin.ai/sessions/0c452d209ec54b068ba120b4c92b8f6c
Requested by: @kinyoklion

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Overview**
> Adds an OpenFeature **feature matrix** to the README so readers can
see at a glance what this provider supports.
> 
> The table mirrors the OpenFeature Ruby SDK feature list (providers,
targeting, hooks, logging, domains, eventing, initialization, shutdown,
tracking, transaction context, extending, flag metadata). Every row is
marked supported, with notes on how the provider implements it or that
the SDK handles it. The legend leaves room for partial/unsupported rows
later.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
898abf3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
kinyoklion pushed a commit that referenced this pull request Aug 25, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](0.2.0...0.3.0)
(2026-08-25)


### Features

* Emit provider events from LaunchDarkly client status
([#29](#29))
([1b53b0c](1b53b0c))
* Populate OpenFeature flag metadata from the evaluation reason
([#31](#31))
([e6ef78a](e6ef78a))
* Report provider name and version to LaunchDarkly
([#30](#30))
([c5dd94d](c5dd94d))
* Support OpenFeature tracking
([#27](#27))
([709f52d](709f52d))
* Support provider initialization and shutdown
([#28](#28))
([27df803](27df803))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Overview**
> **Release 0.3.0** — this PR only bumps version metadata from **0.2.0**
to **0.3.0** in `.release-please-manifest.json`,
`lib/ldclient-openfeature/version.rb`, and the `SDK_VERSION` example in
`PROVENANCE.md`, and adds the **0.3.0** section to `CHANGELOG.md`.
> 
> No provider or SDK logic changes appear in the diff. The new changelog
entry documents features already landed on main: OpenFeature
**tracking**, provider **initialization/shutdown**, **provider events**
from LaunchDarkly client status, **flag metadata** from evaluation
reason, and reporting **provider name/version** to LaunchDarkly.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
8416ff3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PRs created by Devin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants