Skip to content

Fix some tests that were marked as skipped #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmsche merged 1 commit into from
Aug 30, 2026
Merged

Fix some tests that were marked as skipped #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,18 +114,6 @@ parameters:
count: 1
path: tests/LeaptImTestingKernel.php

-
rawMessage: 'Property Leapt\ImBundle\Tests\ManagerTest::$root is never read, only written.'
identifier: property.onlyWritten
count: 1
path: tests/ManagerTest.php

-
rawMessage: Unreachable statement - code above always terminates.
identifier: deadCode.unreachable
count: 3
path: tests/ManagerTest.php

-
rawMessage: 'Method Leapt\ImBundle\Tests\Mock\Process::run() overrides @final method Symfony\Component\Process\Process::run().'
identifier: method.parentMethodFinalByPhpDoc
Expand Down
10 changes: 4 additions & 6 deletions tests/ManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ final class ManagerTest extends TestCase
protected function setUp(): void
{
$this->root = vfsStream::setup('/root');
$this->projectDir = 'vfs://app';
$this->projectDir = 'vfs://root/app';
$this->publicPath = '../public';
$this->cachePath = 'cache/im';
}
Expand Down Expand Up @@ -62,7 +62,6 @@ public function testSetCachePath(Manager $manager): void
#[Depends('testConstruct')]
public function testCacheExists(Manager $manager): void
{
$this->markTestSkipped();
$this->root = vfsStream::setup('/root');
$filepath = 'somefile';
$format = '50x';
Expand All @@ -87,7 +86,6 @@ public function testCacheExists(Manager $manager): void
#[Depends('testConstruct')]
public function testGetCacheContent(Manager $manager): void
{
$this->markTestSkipped();
$structure = [
'app' => [],
'public' => [
Expand Down Expand Up @@ -141,7 +139,8 @@ public function testConvertFormatException(Manager $manager): void
#[Depends('testConstruct')]
public function testCheckImage(Manager $manager): void
{
$this->markTestSkipped();
$this->expectNotToPerformAssertions();

$structure = [
'app' => [],
'public' => [
Expand All @@ -156,8 +155,7 @@ public function testCheckImage(Manager $manager): void
$method = new \ReflectionMethod($manager, 'checkImage');

$method->invoke($manager, 'uploads/somefile');
$method->invoke($manager, 'vfs://public/uploads/somefile');
$this->assertTrue(true);
$method->invoke($manager, 'vfs://root/public/uploads/somefile');
}

#[Depends('testConstruct')]
Expand Down