feat: Support concurrency configuration for kubernetes executor - #977
Open
mlanth wants to merge 1 commit into
Open
feat: Support concurrency configuration for kubernetes executor#977mlanth wants to merge 1 commit into
mlanth wants to merge 1 commit into
Conversation
…compatibility by keeping kubernetes executor unlimited by default when the flag is unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Kubernetes executor either through otfd or otf-agent an unlimited number of jobs can be created and scheduled leading to all cluster resources being consumed and jobs rejected. While resource quotas can be applied to limit the allowed pool, that will just start rejecting jobs sooner.
By supporting the concurrency configuration we can utilize the existing queue used with fork executor and apply our own limits within the application. This allows the administrator to have known restrictions with a maximum workload based on concurrent jobs allowed and job pod resource limits.
Concurrency flag remains backwards compatible leaving fork executor its default of 5 and kubernetes executor unlimited when the flag is unset.