Repository navigation
fix(utils): skip device_context guard under torch.compile (#1590) - #1610
Open
YuvrajSinghBhadoria2 wants to merge 1 commit into
Open
YuvrajSinghBhadoria2 wants to merge 1 commit into
YuvrajSinghBhadoria2 wants to merge 1 commit into
Conversation
) Skip the torch.cuda.device()/torch.xpu.device() context-manager guard when torch.is_compiling() is true. Dynamo emits incorrect device-restore nodes during tracing, which leads to wrong output or illegal memory access (linkedin#1590). Use getattr(torch, 'is_compiling', lambda: False)() so the check is robust on torch versions that do not define torch.is_compiling. Add CPU-runnable unit tests covering the compile-skip path, the non-compile path, CPU device, and backends without a .device attribute.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1590
Skip the torch.cuda.device()/torch.xpu.device() context-manager guard
when torch.is_compiling() is true. Dynamo emits incorrect device-restore
nodes during tracing, which leads to wrong output or illegal memory
access (#1590).
Use getattr(torch, 'is_compiling', lambda: False)() so the check is
robust on torch versions that do not define torch.is_compiling.
Add CPU-runnable unit tests covering the compile-skip path, the
non-compile path, CPU device, and backends without a .device attribute.
All tests verified passing in a CPU-only Docker container (no GPU
required).