Skip to content

--profile is silently ignored in cohort mode #365

Description

@amc-corey-cox

dm-bip seven-bridges submit accepts --profile in both execution modes, but only single-consent acts on it. The cohort branch calls _submit_cohort_mode(...) without passing profile, so Profile never reaches the task body — submit --cohort-mode --profile runs with no diagnostics and reports nothing unusual.

The fix depends on a decision that hasn't been made yet, which is why this is worth writing down rather than patching straight away.

No cohort-mode app exists on any tier except test. dmc-harmonization-multiconsent-app is the only one, and it declares no Profile input. So even if the CLI forwarded the flag, there is currently nowhere for it to land.

That leaves two coherent answers:

  • If a dev-tier cohort app gets created — which is the natural place to exercise and profile cohort mode, given diagnostics belong on dev — then forward profile through _submit_cohort_mode and have that app declare a Profile input, matching cc-dm-bip-test.
  • If cohort mode stays test-and-prod only, reject the combination outright. submit --cohort-mode --profile should fail with a message saying profiling is single-consent only, rather than accepting a flag nothing can act on.

Either is fine; silently accepting it is not. This is the same failure shape as #362 — an input accepted where nothing downstream can honor it — except here the CLI is the one dropping it rather than the app.

Documented as current behavior in RELEASING.md (#364).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BDC ApplicationBring Harmonization to BDC for User ApplicationfutureFuture work — not on current development roadmap

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions