fix: skip empty segment ids for cdp_member_segment_aggs sinks - #4454
Conversation
Signed-off-by: anilb <epipav@gmail.com>
PR SummaryMedium Risk Overview The same non-empty hierarchy id checks are added on organization bucket backfill parent/grandparent nodes ( Reviewed by Cursor Bugbot for commit 6ee609a. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
|
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Pull request overview
Prevents empty hierarchy segment IDs from reaching member and organization aggregate sinks.
Changes:
- Filters empty parent and grandparent segment IDs.
- Applies filters to backfill and daily changed-aggregate sinks.
- PR title still needs the CI-required
(CM-XXX)JIRA key.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
cdp_organization_aggregates_bucket_backfiller_sink.pipe |
Filters invalid organization and hierarchy IDs. |
cdp_member_aggregates_parent_segments_bucket_backfiller_sink.pipe |
Excludes empty parent IDs. |
cdp_member_aggregates_grandparent_segments_bucket_backfiller_sink.pipe |
Excludes empty grandparent IDs. |
cdp_member_aggregates_changed_parent_segments_sink.pipe |
Filters empty parent IDs from daily exports. |
cdp_member_aggregates_changed_grandparent_segments_sink.pipe |
Filters empty grandparent IDs from daily exports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
No description provided.