Repository navigation
fix(litmus-helm-agent): align label selectors with litmus-agent Helm chart - #721
ispeakc0de merged 1 commit into
Conversation
…Helm chart The COMPONENTS/DEPLOYMENTS label selectors in the subscriber-config ConfigMap were hardcoded with `litmuschaos.io/app=` prefix, but the litmus-agent Helm chart deploys components with different labels: - chaos-exporter: `app=chaos-exporter` (not litmuschaos.io/app) - chaos-operator: `name=chaos-operator` (not litmuschaos.io/app) - event-tracker: `app=event-tracker` (not litmuschaos.io/app) - workflow-controller: `app=workflow-controller` (not litmuschaos.io/app) This mismatch caused the subscriber to fail component discovery when deployed via the Helm chart, as no pods matched the selectors. Fixes litmuschaos/litmus#4973 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
|
@Saranya-jena @namkyu1999 @S-ayanide this is ready for review. One-line fix to align the subscriber-config label selectors with the actual labels used by the litmus-agent Helm chart. Without this, the subscriber can't discover any of the agent components when deployed via Helm. |
|
@Jonsy13 @uditgaurav @ispeakc0de could you please review this when you get a chance? Thanks! |
|
Hey @pierluigilenoci |
|
Hi @Jonsy13, @ispeakc0de — gentle ping. Would you be able to review this when you get a chance? Thank you! |
|
Hey @pierluigilenoci @ispeakc0de will review it shortly. |
|
Hi @ispeakc0de, @Jonsy13, @uditgaurav -- friendly follow-up. It's been about two weeks since the last ping with no response. CI is green and the fix is straightforward (aligning label selectors). Could someone please take a look? Happy to address any feedback. Thank you! |
Summary
Fix the hardcoded COMPONENTS/DEPLOYMENTS label selectors in the
litmus-helm-agentsubscriber-config to match the labels actually applied by thelitmus-agentHelm chart.Problem
In
custom/litmus-helm-agent/pkg/litmus/client.go, theprepareInfraConfigMap()function hardcodes label selectors usinglitmuschaos.io/app=prefix:But the
litmus-agentHelm chart (litmus-helm) deploys components with different labels:app=chaos-exporterlitmuschaos.io/app=chaos-exportername=chaos-operatorlitmuschaos.io/app=chaos-operatorapp=event-trackerlitmuschaos.io/app=event-trackerapp=workflow-controllerlitmuschaos.io/app=workflow-controllerThe subscriber uses these selectors to discover and monitor agent components via
LabelSelectorin Kubernetes API calls. The mismatch causes the subscriber to report all components as missing/not-ready.Fix
Update the hardcoded selectors to match the actual Helm chart labels:
These labels match both the litmus-agent Helm chart and the ChaosCenter manifests
INFRA_DEPLOYMENTSvalue.Fixes litmuschaos/litmus#4973
Test plan
go build ./...passes