Repository navigation
Conversation
This was referenced Oct 26, 2026
richerfu
force-pushed
the
ohos/avoid-linux-target
branch
2 times, most recently
from
October 29, 2026 04:35
ef2f8fc to
6e2a42e
Compare
richerfu
force-pushed
the
ohos/avoid-linux-target
branch
from
October 30, 2026 13:45
6e2a42e to
8185068
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OHOS targets report
target_os = "linux". Desktop Linux dependencies and entrypoints must also excludetarget_env = "ohos", otherwise an OHOS build resolves GTK/WebKit and desktop runners.This changes the target guards in
nsh-platform-linux,nsh-linux-hostandnsh-linux-app, preserving the current Linux feature selections.Part 1 of the draft stack: #473 → #474 → #475. All three target
main; the later PRs include the earlier commits. Rebased onto201d780aand kept as drafts for upstream review.Validation
Validation on the combined stack:
cargo test --workspacecargo clippy --workspace --all-targets -- -D warningscargo xtask clippy-ohos(default, dev, API 23 and API 26)cargo xtask ohos --dev(API 20 compilation, linking and SDK staging)uv run --with PyYAML python .github/ci/paths.pyDesktop Linux execution was not repeated on this macOS host. Full-workspace formatting reports existing differences in unchanged upstream files; the changed OHOS files are formatted.
cargo xtask compat: 19 checks passed;checkout_apps_runfailed in four existing scenarios (base Bold frame, macOS Dock tab contents, gallery Stocks row height, and hopper flight-history text). All four failures reproduce identically on unmodified upstreame239619b(the previous base); no fixture or demo was changed to suppress them.After the final main refresh,
cargo test -p nsh-core -p nsh-engine -p nsh-platform-ohospassed, including all 68 OHOS host tests. DataTable column interaction tests passed on upstream and this stack with--trace: 15 commits and 428 mount items in both runs.