Skip to content

fix: allow dots (.) in package names #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhyrro merged 1 commit into from
Oct 18, 2026
Merged

fix: allow dots (.) in package names #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion luxpkgs-rockspec-verifier/lib/luxpkgs_rockspec_verifier/rockspec.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ defmodule LuxpkgsRockspecVerifier.Rockspec do
}) do
sandboxed_state = :luerl_sandbox.init()

Regex.match?(~r/^[a-zA-Z0-9_\-]+$/, expected_name) and
Regex.match?(~r/^[a-zA-Z0-9_\.\-]+$/, expected_name) and
case :luerl_sandbox.run(
rockspec,
%{
Expand Down
2 changes: 1 addition & 1 deletion luxpkgs/lib/luxpkgs/packages/package.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ defmodule Luxpkgs.Packages.Package do
|> cast(attrs, [:name])
|> validate_required([:name])
|> unique_constraint(:name)
|> validate_format(:name, ~r/^[a-zA-Z0-9_\-]+$/)
|> validate_format(:name, ~r/^[a-zA-Z0-9_\.\-]+$/)
# Recast here to prevent the user from changing the package name
|> cast(attrs, [:summary, :description])
|> validate_length(:name, min: 1, max: 20)
Expand Down
16 changes: 13 additions & 3 deletions luxpkgs/lib/luxpkgs_web/controllers/luarocks_api_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,12 @@ defmodule LuxpkgsWeb.LuaRocksApiController do
|> put_status(:service_unavailable)
|> json(%{errors: ["Rockspec verifier service is unavailable"]})

{:error, %Ecto.Changeset{}} ->
put_status(conn, :bad_request)
{:error, %Ecto.Changeset{} = changeset} ->
conn
|> put_status(:bad_request)
|> json(%{
errors: Enum.map(changeset.errors, fn {field, {msg, _}} -> "#{field} #{msg}" end)
})

{:error, reason} ->
conn
Expand Down Expand Up @@ -146,7 +150,13 @@ defmodule LuxpkgsWeb.LuaRocksApiController do

case Req.post(endpoint, json: %{rockspec: rockspec_text}) do
{:ok, %Req.Response{status: 200, body: body}} ->
{:ok, body}
{:ok,
%{
package: body["package"],
version: body["version"],
summary: body["summary"],
description: body["description"]
}}

{:ok, %Req.Response{status: 422}} ->
{:error, :invalid_rockspec}
Expand Down
2 changes: 1 addition & 1 deletion luxpkgs/lib/luxpkgs_web/schemas/package_input.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ defmodule LuxpkgsWeb.Schemas.PackageInput do
type: :string,
description: "Unique package name",
example: "lua-cjson",
pattern: "^[a-zA-Z0-9_-]+$"
pattern: "^[a-zA-Z0-9_.-]+$"
},
summary: %OpenApiSpex.Schema{
type: :string,
Expand Down
Loading