Skip to content

3468 no pickup locations are rendered when customer account shipping address postcode yields no searh results - #3469

Open
novikor wants to merge 2 commits into
magento:developfrom
novikor:3468-No-Pickup-Locations-are-rendered-when-customer-account-shipping-address-postcode-yields-no-searh-results
Open

novikor wants to merge 2 commits into
magento:developfrom
novikor:3468-No-Pickup-Locations-are-rendered-when-customer-account-shipping-address-postcode-yields-no-searh-results

Conversation

@novikor

@novikor novikor commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description (*)

  • Reset locations list after empty-result preselect attempts from saved shipping address.;
  • Unified In-Store Pickup Rest API search criterias.
    locations cache key is sensitive to request data keys order, and calls from different places used to lead to cache misses.

Fixed Issues (if relevant)

  1. Fixes No Pickup Locations are rendered when customer account shipping address postcode yields no searh results #3468

Manual testing scenarios (*)

  1. Log in into account described in preconditions.
  2. Add any product assigned to at least one pickup location to cart
  3. Go to checkout, select 'Pick In Store'
  4. See ' We could not preselect pickup location based on available information, please select it manually.' message, click 'Select Store'
  5. There is a list of locations with the search input is empty.
  6. Open Browser Devtools -> Network, ensure there are no duplicated REST API requests to In Store Pickup

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

locations cache key is sensitive to request data keys order, and calls from different places used to lead to cache misses.
@novikor

novikor commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@magento run all tests

@novikor

novikor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@magento run WebAPI Tests

@novikor

novikor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@magento run Functional Tests

@magento-automated-testing

Copy link
Copy Markdown

Failed to run the builds. Please try to re-run them later.

@novikor

novikor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@magento run failed tests

@magento-automated-testing

Copy link
Copy Markdown

Failed to run the builds. Please try to re-run them later.

@novikor

novikor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Okay.
@magento run Functional Tests B2B
@magento run Functional Tests CE
@magento run Functional Tests EE

@novikor

novikor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@magento run Functional Tests CE

@novikor

novikor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@magento run Functional Tests EE

@novikor

novikor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

@magento run Semantic Version Checker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

No Pickup Locations are rendered when customer account shipping address postcode yields no searh results

1 participant