Stabilize SPA root finding and tail evaluation - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #48 .
SPA’s Newton solver could stall at the cumulant-generating function’s domain boundary and silently fall back to an uncorrected normal p-value, producing large changes in ACAT results between nearly identical null fits.
To address this, we replaced Newton with bisection using finite, sign-changing brackets inside the valid domain. At the same time, we improved numerics overall by computing tail calculations in log space to avoid overflow.
Failed SPA attempts now return NaN rather than silently substituting the normal approximation. Regression tests and plasma chr22 scans confirm that the diagnosed failures are resolved without meaningful default-runtime overhead, although some tolerance dependence remains.