Repository navigation
Develop - #700
Merged
Merged
Develop#700
Conversation
normalize_citations() returns one row per occurrence of a reference, so joining it back on the citation string multiplied a reference cited k times into k x k rows, with dplyr's many-to-many warning. The duplicates were collapsed afterwards, so the results were right, but on 2000 Web of Science records the intermediate table held about 2.55 million rows instead of 130,264; one reference cited 1160 times accounted for about 1.35 million. Occurrences of the same string share their match (only the ids of the filtered references differ, and those rows are dropped right after), so the matches are reduced to one row per string before the join. The four elements of the result compare identical() before and after on the Scopus fixture, a 530-document Scopus and a 2000-document WoS collection.
…aph 2.0/2.1 networkPlot(), histPlot(), networkStat() and net2VOSviewer() still called igraph's dotted names and deprecated arguments, which thematicEvolution() reported as "was deprecated in igraph 2.0.0" warnings. They now use the current API: layout_nicely(), layout_in_circle(), layout_as_star(), layout_on_sphere(), layout_with_mds(), layout_with_kk(), layout_with_fr(), page_rank(), as_edgelist(), igraph::decompose() (not imported, since stats::decompose() is), delete_vertices(), write_graph(), hits_scores() for hub and authority scores, cluster_leiden(resolution = ) and eigen_centrality() without scale and options. Each replacement returns identical() results to the old call with the same seed. Unused deprecated imports are dropped and igraph (>= 2.1.0) is required. The test suite runs without warnings with lifecycle_verbosity = "warning".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Before and after
Checklist
developtestthat::test_dir("tests/testthat")is green, with no failuresNEWSandNEWS.mdhave an entry under the development versionR/,inst/biblioshiny/andNEWSare still pure ASCII