Fix null dereference bug in edit function - #235
Open
Dima-shima wants to merge 1 commit into
Open
Dima-shima wants to merge 1 commit into
Dima-shima wants to merge 1 commit into
Conversation
Dima-shima
commented
Sep 23, 2026
Dima-shima
commented
- Add null check in store.edit() before modifying note
- Return boolean to indicate success/failure (consistent with remove())
- Add error handling in notes.js edit command to handle missing notes
- Prevents crash when editing non-existent note IDs
- Add null check in store.edit() before modifying note - Return boolean to indicate success/failure (consistent with remove()) - Add error handling in notes.js edit command to handle missing notes - Prevents crash when editing non-existent note IDs Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.