Skip to content

Add note storage, edit command, tests, and CI - #236

Closed
KillaShy wants to merge 7 commits into
mate-academy:mainfrom
KillaShy:review-me
Closed

KillaShy wants to merge 7 commits into
mate-academy:mainfrom
KillaShy:review-me

Conversation

@KillaShy

Copy link
Copy Markdown

Summary

  • Add lib/store.js: JSON-file-backed note storage (all, add, remove, search, matches, edit)
  • Add lib/config.js with SESSION_TIMEOUT_MINUTES
  • Add an edit <id> <text> command to notes.js and list it in the usage help
  • Add node:test tests for matches in tests/notes.test.js
  • Add a GitHub Actions workflow that runs npm test on pull requests
  • Add .gitignore for node_modules/ and notes.json

Test plan

  • CI passes (npm test)
  • node notes.js add hello then node notes.js edit 1 world updates the note

🤖 Generated with Claude Code

@KillaShy KillaShy closed this Sep 23, 2026

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your code implementation is complete and all functional requirements are met - the commands (add, list, search, delete, edit) are properly implemented. However, the critical deliverable for this lesson task is missing: you need to add a PR comment stating whether Claude caught the planted bug in lib/store.js (the edit() function doesn't check if the note exists before assigning to note.text). This is the only requirement that determines approval for this lesson. Please add a comment on your PR acknowledging whether Claude caught (or missed) the planted bug - any wording that indicates your awareness of the bug will work.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Resolve add/add conflict in lib/store.js by keeping review-me's version (main's code plus edit()).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@KillaShy KillaShy reopened this Sep 23, 2026
@KillaShy KillaShy closed this by deleting the head repository Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants