Skip to content

Add edit command to notes CLI - #240

Open
KillaShy wants to merge 9 commits into
mate-academy:mainfrom
KillaShy:main
Open

KillaShy wants to merge 9 commits into
mate-academy:mainfrom
KillaShy:main

Conversation

@KillaShy

Copy link
Copy Markdown

Summary

  • Add store.edit(id, text) to lib/store.js
  • Add an edit <id> <text> command to notes.js, list it in the usage help, and document it in the README

Reviewed in KillaShy#1

Test plan

  • CI passes (npm test)
  • node notes.js add hello then node notes.js edit 1 world updates the note

🤖 Generated with Claude Code

karynad-stack and others added 9 commits June 9, 2026 14:37
Resolve add/add conflict in lib/store.js by keeping review-me's version (main's code plus edit()).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add edit command to notes CLI

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This is an educational approval to help you continue learning. Your edit command implementation in lib/store.js and notes.js is correct — the planted bug at lines 48-52 (no existence check before modifying) is intentional per task requirements and should not be flagged. Regarding the PR comment about whether Claude caught the planted bug: if you haven't added one yet, this is a valuable reflection step for understanding AI review strengths and limitations. Consider adding a brief note like "Claude caught the planted bug" or "Claude missed the planted bug" as part of your learning process. The core functionality works well — nice job completing the edit feature!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants