Skip to content

Read environ handshake before starting input reader #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattn merged 1 commit into from
Jul 10, 2026
Merged

Read environ handshake before starting input reader #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,20 @@ func client(addr string, args []string) int {
defer errw.Close()
cmd.Stderr = errw

var environ []string
err = dec.Decode(&environ)
if err != nil {
enc.Encode(&msg{Name: "error", Error: fmt.Sprintf("cannot execute command: %v", makeCmdLine(args))})
return 1
}
cmd.Env = environ

go func() {
defer inw.Close()
in_loop:
for {
var m msg
err = dec.Decode(&m)
if err != nil {
if err := dec.Decode(&m); err != nil {
return
}
switch m.Name {
Expand All @@ -69,14 +76,6 @@ func client(addr string, args []string) int {
}
}()

var environ []string
err = dec.Decode(&environ)
if err != nil {
enc.Encode(&msg{Name: "error", Error: fmt.Sprintf("cannot execute command: %v", makeCmdLine(args))})
return 1
}
cmd.Env = environ

err = cmd.Run()

code := 1
Expand Down
Loading