ci(release): create the GitHub release after publishing - #21
Merged
Merged
Conversation
Glama builds and lists a new version only for a GitHub release, not for a bare tag, so v1.1.0 stayed at 1.0.0 there until a release was created by hand. The last job of the release workflow now creates the release with generated notes once npm, GHCR and the registry have the version, and leaves an existing release alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glama's Auto-Release builds and lists a new version only for a GitHub release, not a bare tag. The repository had tags and no releases, so Glama stayed at 1.0.0 after v1.1.0 until a release was created by hand today.
A final
github-releasejob, afterregistry, creates the release for the tag with generated notes. It runs only once every artifact the release announces exists, and it leaves an existing release (such as one written by hand) alone. It is the only job withcontents: write. The README's release paragraph says so.Test plan
v1.1.0: it detects the existing release and exits 0 without changesv*tag