Skip to content

Fix Poetry setup on Python 3.9 - #676

Merged
michaelfeil merged 1 commit into
mainfrom
codex/fix-poetry-python39
Oct 10, 2026
Merged

michaelfeil merged 1 commit into
mainfrom
codex/fix-poetry-python39

Conversation

@michaelfeil

Copy link
Copy Markdown
Owner

Python 3.9 CI fails before linting because pipx exposes the runner's shared pip to the Poetry environment. That pip uses dataclass(slots=True), which Python 3.9 cannot execute. The failure is visible in the setup logs.

Install the requested Poetry version in a fresh virtual environment created by the selected Python, using that environment's own pip. Restore the existing dependency caches before installation, and replace the cached pipx environment and its hardcoded symlink repair with a portable setup. Expose only the Poetry launcher on PATH so subsequent python and pip commands keep using the selected project interpreter.

Add a lightweight setup workflow for Python 3.9 and 3.12 on Ubuntu and Windows. It verifies the Poetry version, checks that setup does not shadow Python, and installs/runs a dependency-free project.

Validation

  • Executed the action's installation step and workflow's smoke-test step locally on Python 3.9.25 and 3.12.15, twice each, using temporary paths containing spaces. All four runs passed.
  • actionlint 1.7.7 passes for the new workflow and existing test/lint/CI callers (optional shellcheck/pyflakes integrations disabled).
  • git diff --check passes.
  • Windows execution is covered by the new GitHub Actions matrix and awaits CI.

Related issue

Addresses the pre-existing setup failure observed in #675. This PR is based directly on main and contains only the setup fix and its smoke-test workflow.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T02:41:28.164482Z ae65d7a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge; no blocking issues were found.

Summary

This PR installs Poetry in a fresh environment created by the selected Python, replacing pipx and its hardcoded path repair.

  • Poetry runs in its own environment without replacing the project Python.
  • A setup check runs on Python 3.9 and 3.12 on Ubuntu and Windows.

Reviews (1) · Last reviewed commit: "Isolate Poetry installation from pipx sh..." · Reviewed by Greptile

@codecov-commenter

codecov-commenter commented Oct 10, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.00%. Comparing base (1eb4396) to head (ae65d7a).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   80.05%   80.00%   -0.06%     
==========================================
  Files          43       43              
  Lines        3485     3485              
==========================================
- Hits         2790     2788       -2     
- Misses        695      697       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelfeil
michaelfeil merged commit 040269b into main Oct 10, 2026
40 checks passed
@michaelfeil
michaelfeil deleted the codex/fix-poetry-python39 branch October 10, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants