Repository navigation
fix: capture safe token-count unavailable diagnostics - #144
Conversation
|
Exact-head offline validation completed for All six jobs passed (Linux/macOS/Windows, Python 3.11/3.12), each with 2657 passed, 1 deselected, 48 warnings. The deselected case is the existing separately authorized live-vision gate, which remains UNMET. Final transport cases explicitly use No DTU, live provider request, dependency adoption, merge, release, or original-chat continuation was performed. The historical count-failure cause and original-chat recovery remain unproven. Draft stays open for parent-owned Astra/Fable exact-head review and coordinated combined isolated qualification. |
Problem
request_budget()returnsNoneon count failures, but safe warnings can be absent from captured sessions. The original Fable count-failure cause remains unknown. This PR adds diagnostics only; it does not claim original-chat recovery.Change
provider:token_count_unavailablethrough existing coordinator hooks; mount now contributes its name toobservability.eventsunderprovider-anthropic, so discovery-based observers subscribe.None, cancellation, API-call count, deadlines, retry and fit semantics. SDK timeout is classified astimeout. Ordinary diagnostic failures cannot changeNone.Tests and capture boundary
The existing offline suite covers real-SDK MockTransport HTTP429/400, timeout, malformed and valid counts; JSON/privacy, no extra requests, missing/failing observer, deadline and cancellation tests.
Review repair adds:
None, and no extra SDK calls.Boundary: the Core subscriber is not the actual Context Intelligence LoggingHandler. Canonical CI discovery/subscription/writer source was inspected at
bf7cfbc82bdfd356e86f7a849622772537956b17. Actual CI-hook capture remains an explicit paired isolated qualification gate handed to parent/worker87, with local-only destinations and synthetic session identity. No dependency was added solely to simulate that gate.Exact-head validation
Current head
e10499b8c9a15d21aa0904b7d0567318e5bc0048: all six ordinary CI jobs passed on Linux/macOS/Windows, Python3.11/3.12: 2659 passed, 1 deselected, 48 warnings per job.https://github.com/microsoft/amplifier-module-provider-anthropic/actions/runs/43661350635
Host AST-only parsing and diff checks passed; working tree clean. No host pytest/install, DTU, live provider call, production capture or original-session/config access. The existing separately authorized live-vision test remains deselected/UNMET.
Earlier repair head
0c6c8c7failed only its new strict Core-envelope assertion because Core adds a timestamp; event delivery and JSON write succeeded. Final test accounts for that field explicitly. Priorc23cff5green did not prove observer discovery.Scope and remaining gates
Based on main
3204656f784af914de2c3d7d6f7175ad904a00db. Only provider diagnostics/mount registration, request-budget tests and existing README changed. No model/media, context or streaming-loop files. PR133/142 edit this module elsewhere; contextPR38/streamingPR74 retain their owners.Keep draft: parent Astra/Fable exact-head source closure and actual CI observer capture in coordinated combined isolated qualification are required before merge/adoption. No merge, adoption, serving changes or release is included.