You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This looks fixed on main by #21135 (merge commit 4aaaca1, merged 2026-10-19 13:20 UTC), so I suggest closing it.
What failed. The failing assertion here is Assert.Equal(CliExitCodes.Success, await run…): Expected 0, Actual 7. Exit code 7 is CliExitCodes.FailedToFindProject. It does not count reconciliations. When the test cancelled, TrayWatchStream.RunAsync could see the producer complete its update channel before the pending read observed cancellation. if (!await pendingRead) return CliExitCodes.FailedToFindProject; then treated a normal shutdown as a discovery failure. That is why several different tests in TrayWatchStreamTests failed at their final await run with the same 0 vs 7.
The fix.#21135 changed that branch to return CliExitCodes.Success. Real discovery and limit failures still arrive as terminal error updates. It also added a deterministic regression test that forces channel completion to win the race. That test failed with 0/7 before the fix.
Evidence that no occurrence happened after the fix. Every occurrence recorded in this family (#20707, #20772, #20929, #21032, #20749) ran on main from 2026-10-03 to 2026-10-19. The latest, run 39247121741, started 2026-10-19 11:46 UTC on 125cdfb. That is an ancestor of 4aaaca1 and started before #21135 merged. No occurrence has been recorded since.
Closure recommendation: no recurrence in 7 days of CI
Window: ci.yml attempt-1 runs from 2026-10-25T10:57Z to 2026-11-01T09:51Z (824 runs). I grepped every failed test-job log in that window (968 of 968 downloaded).
Test: TrayWatchStreamTests.UnacknowledgedDashboardCancellationCannotAccumulateRequestsAcrossSnapshots, both saturateSlots cases. Still present and not skipped on main (1bccada).
Aspire.Cli.Tests lane jobs: main 63 Linux / 58 macOS / 63 Windows, PR 216 Linux / 202 macOS / 215 Windows.
Activity
davidfowl commentedon Oct 31, 2026
This looks fixed on
mainby #21135 (merge commit 4aaaca1, merged 2026-10-19 13:20 UTC), so I suggest closing it.What failed. The failing assertion here is
Assert.Equal(CliExitCodes.Success, await run…): Expected 0, Actual 7. Exit code 7 isCliExitCodes.FailedToFindProject. It does not count reconciliations. When the test cancelled,TrayWatchStream.RunAsynccould see the producer complete its update channel before the pending read observed cancellation.if (!await pendingRead) return CliExitCodes.FailedToFindProject;then treated a normal shutdown as a discovery failure. That is why several different tests inTrayWatchStreamTestsfailed at their finalawait runwith the same 0 vs 7.The fix. #21135 changed that branch to return
CliExitCodes.Success. Real discovery and limit failures still arrive as terminal error updates. It also added a deterministic regression test that forces channel completion to win the race. That test failed with 0/7 before the fix.Evidence that no occurrence happened after the fix. Every occurrence recorded in this family (#20707, #20772, #20929, #21032, #20749) ran on
mainfrom 2026-10-03 to 2026-10-19. The latest, run 39247121741, started 2026-10-19 11:46 UTC on 125cdfb. That is an ancestor of 4aaaca1 and started before #21135 merged. No occurrence has been recorded since.🤖 Posted by AspireAgent (AI Agent)
davidfowl commentedon Nov 1, 2026
Closure recommendation: no recurrence in 7 days of CI
TrayWatchStreamTests.UnacknowledgedDashboardCancellationCannotAccumulateRequestsAcrossSnapshots, bothsaturateSlotscases. Still present and not skipped on main (1bccada).I recommend closing this. Reopen it if the signature comes back.
🤖 Posted by AspireAgent (AI Agent)