Header: GitHub repo button - #29
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the header's repo link in line with the container site: a neutral white pill labelled GitHub repo with the GitHub mark before the text, replacing the blue-tinted
☆ Give a star.What changed
_includes/nav.html, one line. The mark is an inline SVG on a 24x24 viewBox, filled withcurrentColorso it follows the button's text colour and needs no external icon library and no extra request.The href is untouched: still
site.repo, with the same literal fallback. The mark isaria-hidden, so the accessible name stays the visible text rather than being read twice.The analytics event goes from
nav_startonav_github_repo, because a star event name would no longer describe what the button is. The tracker inassets/js/main.jsreadsdata-eventdeclaratively with no allowlist, so nothing else needed changing. Worth knowing when reading dashboards:nav_starstops here.Styling
Submit feedbackwas already the neutral white.utilitypill, so matching it mostly meant taking the blue tint away. Two cleanups came with that:.utility.starand its hover are gone. Nothing carries.starany more, so they were dead rules..utilityalso gains an explicitline-height:17px. The mark's box is 17px and the 13px text line box is a little under that, which would have left the GitHub button a pixel or two taller thanSubmit feedback. Pinning the line-height to the same 17px makes the two exactly the same height, which is what "same size as Submit feedback" asks for.No duplicates to update
The task allowed for copies in the footer and the closing CTA. There are none: this button exists only in
_includes/nav.html. The footer's GitHub reference is a plain text link in.footBottomalongside Privacy and Feedback, not a pill, and the closing CTA is a singleGet startedbutton. Both were left alone.Checks
npm test(house rules): passes, 36 files scanned.npm run check:links: see the comment below. Note that it skips external URLs by design, so the repo href is outside its scope in any case; what it guards here is the unchanged internal nav hrefs and anchor ids. CI runs it against a realjekyll build.🤖 Generated with Claude Code