Repository navigation
Disambiguate object serializer stream on .NET 11 - #2385
Open
Rui Chen (chenrui333) wants to merge 1 commit into
Open
Rui Chen (chenrui333) wants to merge 1 commit into
Rui Chen (chenrui333) wants to merge 1 commit into
Conversation
Use the Garnet.common type explicitly through an alias so the streaming constructor and XML reference remain unambiguous when System.Buffers also exposes ReadOnlySequenceStream. Signed-off-by: Rui Chen <rui@chenrui.dev>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the stream-alias change, although a net11.0 build remains unverified.
No open issues 🎉
What changed in this PR
Resolves the .NET 11 ReadOnlySequenceStream name ambiguity in Garnet’s object serializer without changing serialization behavior.
Changes:
- Adds a file-scoped alias for
Garnet.common.ReadOnlySequenceStream, disambiguating both the constructor and XML documentation reference.
A net11.0 build remains unverified.
| File | Description |
|---|---|
libs/server/Objects/Types/GarnetObjectSerializer.cs |
Adds an explicit alias selecting Garnet’s stream implementation. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building Garnet 2.2.12 for
net11.0fails with CS0104 inGarnetObjectSerializer.Deserialize: bothSystem.BuffersandGarnet.commonexposeReadOnlySequenceStream. This was encountered in Homebrew/homebrew-core#325463.Change
Add a file-scoped alias for
Garnet.common.ReadOnlySequenceStream, following the existing alias convention inRespCommandDataProvider.cs. This disambiguates both the constructor and its XML documentation reference without changing the stream implementation or serialization behavior.Validation
git apply --check.Garnet.server.csprojbuild fornet11.0remains required.