Repository navigation
Restore lockfile-only Dependabot updates and fix npm alerts - #400
Merged
Vladimir Morozov (vmoroz) merged 1 commit intoOct 30, 2026
Merged
Conversation
Revert the versioning-strategy change from microsoft#398. increase-if-necessary also applies to version updates, so Dependabot proposed every npm major (microsoft#399). Restore lockfile-only and the grouped security updates. Fix the alerts that lockfile-only updates cannot reach: - tools/hermes-parser/js: pin @babel/core 7.29.7, force patch-package's tmp to ^0.2.7, and lock glob 10.5.0. - benchmarks/widgets/original/es5: override micromatch, braces and serialize-javascript; the webpack output is unchanged. Add npmMinimalAgeGate: "8d" to .yarnrc.yml so Yarn never pins a version that the react-native-public feed still holds back. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the changes restoring lockfile-only updates and addressing dependency security alerts.
No open issues 🎉
1 file not reviewed
benchmarks/widgets/original/es5/package-lock.json: Generated file
What changed in this PR
Restores lockfile-only Dependabot updates after #398 led to unwanted major-version upgrades, and manually updates dependencies to address npm security alerts without replacing webpack 4.
Changes:
- Restore grouped npm security updates and the
lockfile-onlystrategy. - Add an eight-day Yarn minimum package age matching the Dependabot cooldown.
- Update parser tooling dependencies and override vulnerable ES5 benchmark dependencies, removing the old micromatch dependency chain.
| File | Description |
|---|---|
tools/hermes-parser/js/yarn.lock |
Deduplicates Babel core and updates locked glob and tmp versions. |
tools/hermes-parser/js/package.json |
Pins Babel core 7.29.7 and adds a targeted tmp resolution. |
benchmarks/widgets/original/es5/package.json |
Adds security overrides for braces, micromatch, and serialize-javascript. |
benchmarks/widgets/original/es5/package-lock.json |
Locks overridden versions and removes obsolete transitive dependencies. |
.yarnrc.yml |
Adds an eight-day minimum package age for Yarn resolution. |
.github/dependabot.yml |
Restores lockfile-only updates and npm security grouping. |
Review effort: Balanced
Nikolai Aristov (NikoAri)
approved these changes
Oct 30, 2026
Benchmark ResultsTotal benchmarks: 204 Inputs: baseline/baseline.json, bench_result.json v8 (6176ms, 6417ms) +3.9%
test-suites (317886ms, 309174ms) -2.7%
micros (60876ms, 61245ms) +0.6%
jit-benches (8563ms, 6216ms) -27.4%
many-subclasses (73437ms, 76110ms) +3.6%
map-objects (3627ms, 3621ms) -0.2%
map-strings (4335ms, 4333ms) -0.0%
nbody (3448ms, 2890ms) -16.2%
string-switch (6503ms, 6380ms) -1.9%
raytracer (5608ms, 5598ms) -0.2%
MiniReact (30332ms, 29969ms) -1.2%
widgets (12934ms, 12871ms) -0.5%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#398 switched the npm Dependabot entry from
versioning-strategy: lockfile-onlytoincrease-if-necessaryto unblock security updates. That setting also governsversion updates, so the next run tried to move npm dependencies to their newest
majors: 23 errors and a 40-update PR (#399) with Babel 8, Jest 30, ESLint 10 and
yargs 18. The security failures #398 targeted are not a config problem: each fix
needs a parent package moved out of its semver range, which lockfile-only updates
can't do. This PR restores the known-good config and makes those fixes by hand.
Dependabot config
lockfile-onlyagain, with theall-npm-security-updatesgroup, soversion updates stay within existing ranges and security fixes land as one PR.
Yarn age gate
npmMinimalAgeGate: "8d"to the root.yarnrc.yml, which every Yarn projectinherits. The
react-native-publicfeed holds new upstream versions for 7 days,so Yarn should never pin anything younger. This matches the existing 8-day
Dependabot cooldown.
hermes-parser JS packages
@babel/coreto 7.29.7 (from 7.16.5) and dedupe every locked copy onto it.patch-package'stmpto^0.2.7with a Yarn resolution. patch-package 8would fix it directly, but it adds a dependency the feed can't serve anonymously.
glob@^10.4.1(used by jest's coverage) at 10.5.0 instead of 10.4.2.Widgets ES5 benchmark
overridesformicromatch,bracesandserialize-javascript, keepingwebpack 4. This drops the old
micromatch@3chain (77 packages, includingdecode-uri-component) without changing the generated bundle.This fixes 10 of the 14 open npm alerts. The other four (
ellipticin the ES5benchmark,
deepmergevia jest-config and@rollup/plugin-node-resolve) have nopatched release and are only used at build or test time.
Test Plan
npm run npm-source-lint(in.ado/scripts): 12 projects, 0 violations.npm run test:npm-source-lint: pass.tools/hermes-parser/js:yarn install --immutablepasses, and the postinstallpatch-packagestill applies its patch.yarn babel <workspace>/srccompiles allsix workspaces with
@babel/core7.29.7. Jest wasn't run; it needs the WASMparser build.
benchmarks/widgets/original/es5:npm ciandnpm run buildpass, and theoutput is byte-identical to a build from the previous lockfile.
alert's vulnerable range against the new lockfiles shows 10 fixed.
Microsoft Reviewers: Open in CodeFlow