Skip to content

Restore lockfile-only Dependabot updates and fix npm alerts - #400

Merged
Vladimir Morozov (vmoroz) merged 1 commit into
microsoft:mainfrom
vmoroz:PR/dependabot-lockfile-only
Oct 30, 2026
Merged

Vladimir Morozov (vmoroz) merged 1 commit into
microsoft:mainfrom
vmoroz:PR/dependabot-lockfile-only

Conversation

@vmoroz

@vmoroz Vladimir Morozov (vmoroz) commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Summary

#398 switched the npm Dependabot entry from versioning-strategy: lockfile-only to
increase-if-necessary to unblock security updates. That setting also governs
version updates, so the next run tried to move npm dependencies to their newest
majors: 23 errors and a 40-update PR (#399) with Babel 8, Jest 30, ESLint 10 and
yargs 18. The security failures #398 targeted are not a config problem: each fix
needs a parent package moved out of its semver range, which lockfile-only updates
can't do. This PR restores the known-good config and makes those fixes by hand.

Dependabot config

Yarn age gate

  • Add npmMinimalAgeGate: "8d" to the root .yarnrc.yml, which every Yarn project
    inherits. The react-native-public feed holds new upstream versions for 7 days,
    so Yarn should never pin anything younger. This matches the existing 8-day
    Dependabot cooldown.

hermes-parser JS packages

  • Pin @babel/core to 7.29.7 (from 7.16.5) and dedupe every locked copy onto it.
  • Force patch-package's tmp to ^0.2.7 with a Yarn resolution. patch-package 8
    would fix it directly, but it adds a dependency the feed can't serve anonymously.
  • Lock glob@^10.4.1 (used by jest's coverage) at 10.5.0 instead of 10.4.2.

Widgets ES5 benchmark

  • Add npm overrides for micromatch, braces and serialize-javascript, keeping
    webpack 4. This drops the old micromatch@3 chain (77 packages, including
    decode-uri-component) without changing the generated bundle.

This fixes 10 of the 14 open npm alerts. The other four (elliptic in the ES5
benchmark, deepmerge via jest-config and @rollup/plugin-node-resolve) have no
patched release and are only used at build or test time.

Test Plan

  • npm run npm-source-lint (in .ado/scripts): 12 projects, 0 violations.
    npm run test:npm-source-lint: pass.
  • tools/hermes-parser/js: yarn install --immutable passes, and the postinstall
    patch-package still applies its patch. yarn babel <workspace>/src compiles all
    six workspaces with @babel/core 7.29.7. Jest wasn't run; it needs the WASM
    parser build.
  • benchmarks/widgets/original/es5: npm ci and npm run build pass, and the
    output is byte-identical to a build from the previous lockfile.
  • Every newly locked version downloads anonymously from the feed. Checking each open
    alert's vulnerable range against the new lockfiles shows 10 fixed.
Microsoft Reviewers: Open in CodeFlow

Revert the versioning-strategy change from microsoft#398. increase-if-necessary
also applies to version updates, so Dependabot proposed every npm major
(microsoft#399). Restore lockfile-only and the grouped security updates.

Fix the alerts that lockfile-only updates cannot reach:
- tools/hermes-parser/js: pin @babel/core 7.29.7, force patch-package's
  tmp to ^0.2.7, and lock glob 10.5.0.
- benchmarks/widgets/original/es5: override micromatch, braces and
  serialize-javascript; the webpack output is unchanged.

Add npmMinimalAgeGate: "8d" to .yarnrc.yml so Yarn never pins a version
that the react-native-public feed still holds back.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 30, 2026 21:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the changes restoring lockfile-only updates and addressing dependency security alerts.

No open issues 🎉

1 file not reviewed
  • benchmarks/widgets/original/es5/package-lock.json: Generated file
What changed in this PR

Restores lockfile-only Dependabot updates after #398 led to unwanted major-version upgrades, and manually updates dependencies to address npm security alerts without replacing webpack 4.

Changes:

  • Restore grouped npm security updates and the lockfile-only strategy.
  • Add an eight-day Yarn minimum package age matching the Dependabot cooldown.
  • Update parser tooling dependencies and override vulnerable ES5 benchmark dependencies, removing the old micromatch dependency chain.
File Description
tools/​hermes-parser/​js/​yarn.lock Deduplicates Babel core and updates locked glob and tmp versions.
tools/​hermes-parser/​js/​package.json Pins Babel core 7.29.7 and adds a targeted tmp resolution.
benchmarks/​widgets/​original/​es5/​package.json Adds security overrides for braces, micromatch, and serialize-javascript.
benchmarks/​widgets/​original/​es5/​package-lock.json Locks overridden versions and removes obsolete transitive dependencies.
.yarnrc.yml Adds an eight-day minimum package age for Yarn resolution.
.github/​dependabot.yml Restores lockfile-only updates and npm security grouping.

Review effort: Balanced

@vmoroz
Vladimir Morozov (vmoroz) merged commit 6aaa8bf into microsoft:main Oct 30, 2026
14 checks passed
@vmoroz
Vladimir Morozov (vmoroz) deleted the PR/dependabot-lockfile-only branch October 30, 2026 22:08
@github-actions

Copy link
Copy Markdown

Benchmark Results

Total benchmarks: 204

Inputs: baseline/baseline.json, bench_result.json

v8 (6176ms, 6417ms) +3.9%
v8 hermes (CI) hermes (CI)
v8-crypto 622.6ms 646.2ms
v8-deltablue 739.4ms 808.8ms
v8-raytrace 127.8ms 128.4ms
v8-regexp 593ms 684ms
v8-richards 937ms 900.8ms
v8-splay 225.2ms 236.2ms
v8-crypto (static) 452ms 442.4ms
v8-deltablue (static) 661.6ms 667.8ms
v8-raytrace (static) 91.8ms 95.4ms
v8-regexp (static) 749.2ms 799.4ms
v8-richards (static) 781.4ms 805ms
v8-splay (static) 195ms 202.8ms
test-suites (317886ms, 309174ms) -2.7%
test-suites hermes (CI) hermes (CI)
box2d 2949.8ms 2648ms
earley-boyer 2564.8ms 2613ms
navier-stokes 5743.8ms 4752.6ms
pdfjs 1038.2ms 944.2ms
gbemu 2296ms 2219ms
code-load 4472.8ms 4542.6ms
typescript 3381.8ms 3232.8ms
simpleSum 8855.4ms 5675.4ms
propAccess 2691.2ms 2188.2ms
allocObj 252ms 192ms
allocObjLit 6371.8ms 6244.6ms
allocNewObj 20053ms 19790.2ms
allocArray 249ms 191.8ms
allocNewArray 34956.8ms 34680.8ms
arrayRead 115.6ms 86ms
arrayReadByIndex 550ms 609.2ms
largeArrayRead 827.2ms 531ms
arrayWrite 261.8ms 242ms
largeArrayWrite 2218ms 2083.4ms
interp-dispatch 2880ms 1953.8ms
wb-perf 8327ms 9627.2ms
arrayReverse 40.6ms 36.4ms
arrayMap 1472.6ms 1484.6ms
arrayIndexOf 143.2ms 139.4ms
arrayLastIndexOf 148.6ms 147.2ms
arrayEvery 2308.8ms 2255.8ms
arraySome 2174.4ms 2234ms
arrayFill 2401.2ms 2428.4ms
arrayFilter 1866.4ms 1890.4ms
arrayFind 3207ms 3327.8ms
arrayFindIndex 3322ms 3320ms
arrayPop 1031.4ms 1035.8ms
arrayReduce 1994.2ms 2094.6ms
arrayReduceRight 2075.8ms 2087.6ms
arrayShift 2065.8ms 2075.8ms
arrayUnshift 2109.4ms 2113.8ms
arrayIncludes 1216.6ms 1196.2ms
arrayFrom 1102.8ms 1164.8ms
arrayCopyWithin 1487ms 1511.8ms
stringFromCharCode 92.6ms 89.6ms
arraySlice 786.2ms 795.6ms
arraySplice 26.8ms 27ms
arrayOf 1048.8ms 1036ms
stringCharAt 1346.6ms 1287ms
stringMatch 3192.4ms 2946.8ms
stringSearch 3508.2ms 2927.2ms
stringStartsWith 701ms 592.4ms
stringEndsWith 650.4ms 539.4ms
stringIncludes 1520.6ms 1709ms
stringIndexOf 1555.6ms 1967.6ms
stringLastIndexOf 1821.4ms 1948.6ms
stringSplit 822ms 807ms
stringSlice 490ms 491ms
stringPadStart 2910.8ms 2923.6ms
stringPadEnd 2910ms 2924.8ms
regExpMatch 1506.2ms 1515.4ms
regExpSearch 1227ms 1230.8ms
regExpToString 1204ms 1053ms
stringReplace 1394.8ms 1530.4ms
regExpReplace 3309.2ms 861.4ms
regExpFlags 956.8ms 966.8ms
regExpSplit 1307.8ms 1277ms
numberArrayReadWrite 2477.8ms 2358.6ms
protoCache 3594.6ms 2357.8ms
box2d (static) 1792.6ms 1839.4ms
earley-boyer (static) 1875.6ms 1840ms
navier-stokes (static) 3410.2ms 3459ms
pdfjs (static) 812.8ms 800ms
gbemu (static) 1797ms 1757.2ms
code-load (static) 4199.2ms 4240.6ms
typescript (static) 2685.6ms 2690.8ms
simpleSum (static) 936.2ms 937.6ms
propAccess (static) 2298ms 2332.8ms
allocObj (static) 0.2ms 0.2ms
allocObjLit (static) 4154.4ms 4193ms
allocNewObj (static) 15749.2ms 15654.8ms
allocArray (static) 0.6ms 1ms
allocNewArray (static) 28494.2ms 28533.2ms
arrayRead (static) 74.2ms 67.8ms
arrayReadByIndex (static) 453.2ms 453ms
largeArrayRead (static) 552.2ms 527.8ms
arrayWrite (static) 178.4ms 178.8ms
largeArrayWrite (static) 1568.6ms 1650.6ms
interp-dispatch (static) 1918.8ms 1910.8ms
wb-perf (static) 8991.2ms 9067.6ms
arrayReverse (static) 37ms 37ms
arrayMap (static) 1064.8ms 980ms
arrayIndexOf (static) 128.2ms 128.4ms
arrayLastIndexOf (static) 138.8ms 138.6ms
arrayEvery (static) 1397.6ms 1409.8ms
arraySome (static) 1406.6ms 1407.2ms
arrayFill (static) 1969.2ms 2003.2ms
arrayFilter (static) 1061ms 1062ms
arrayFind (static) 2242.2ms 2245.4ms
arrayFindIndex (static) 2235.8ms 2271.4ms
arrayPop (static) 878ms 915ms
arrayReduce (static) 1311.8ms 1326ms
arrayReduceRight (static) 1322.6ms 1320.4ms
arrayShift (static) 1512ms 1524ms
arrayUnshift (static) 1568.2ms 1588.4ms
arrayIncludes (static) 963.4ms 942ms
arrayFrom (static) 1030.6ms 1023.6ms
arrayCopyWithin (static) 1109.6ms 1181ms
stringFromCharCode (static) 77ms 77.6ms
arraySlice (static) 571.6ms 576.4ms
arraySplice (static) 26ms 26.6ms
arrayOf (static) 868.8ms 874.8ms
stringCharAt (static) 1100.6ms 1105.8ms
stringMatch (static) 2227.6ms 2313.4ms
stringSearch (static) 2219.2ms 2307ms
stringStartsWith (static) 494.2ms 493.8ms
stringEndsWith (static) 457.8ms 455ms
stringIncludes (static) 1437.4ms 1676.4ms
stringIndexOf (static) 1440.8ms 1680ms
stringLastIndexOf (static) 1956.6ms 2201.2ms
stringSplit (static) 651.2ms 666.6ms
stringSlice (static) 445.6ms 436.2ms
stringPadStart (static) 2294.4ms 2424.2ms
stringPadEnd (static) 2499.2ms 2428.6ms
regExpMatch (static) 1483.2ms 1575.2ms
regExpSearch (static) 1296.2ms 1226.2ms
regExpToString (static) 1326.6ms 1052.6ms
stringReplace (static) 1455.6ms 1533.4ms
regExpReplace (static) 851.8ms 854ms
regExpFlags (static) 870.6ms 819.4ms
regExpSplit (static) 1200ms 1119.2ms
numberArrayReadWrite (static) 2132.8ms 2099ms
protoCache (static) 3595.8ms 3755.8ms
micros (60876ms, 61245ms) +0.6%
micros hermes (CI) hermes (CI)
getNodeById.js 5273ms 4704.4ms
setInsert.js 2864.8ms 2945.6ms
stringify-number.js 1823.4ms 1845.2ms
typed-array-sort.js 22381ms 22599.4ms
getNodeById.js (static) 3941ms 4052.4ms
setInsert.js (static) 2517.6ms 2460.4ms
stringify-number.js (static) 1663.6ms 1612.2ms
typed-array-sort.js (static) 20411.4ms 21025.2ms
jit-benches (8563ms, 6216ms) -27.4%
jit-benches hermes (CI) hermes (CI)
idisp.js 2810.2ms 1903ms
idispn.js 3395.8ms 2013ms
idisp.js (static) 1906ms 1913.2ms
idispn.js (static) 450.8ms 386.4ms
many-subclasses (73437ms, 76110ms) +3.6%
many-subclasses hermes (CI) hermes (CI)
many.js 19104.8ms 18300ms
many-sh-1.js 7322.8ms 8119ms
many-sh-2.js 7329ms 8117.2ms
many-sh-3.js 7083.6ms 8024ms
many-sh-4.js 7235ms 8021.8ms
many.js (static) 15996ms 16006.4ms
many-sh-1.js (static) 2285.2ms 2278.4ms
many-sh-2.js (static) 2387ms 2491.2ms
many-sh-3.js (static) 2347.2ms 2379.6ms
many-sh-4.js (static) 2346ms 2372ms
map-objects (3627ms, 3621ms) -0.2%
map-objects hermes (CI) hermes (CI)
map-objects-untyped.js 1023.6ms 1007.2ms
map-objects-typed.js 957.6ms 945.2ms
map-objects-untyped.js (static) 917.2ms 925.6ms
map-objects-typed.js (static) 728.8ms 743.2ms
map-strings (4335ms, 4333ms) -0.0%
map-strings hermes (CI) hermes (CI)
map-strings-untyped.js 1196.8ms 1164.4ms
map-strings-typed.js 1139.2ms 1102.2ms
map-strings-untyped.js (static) 1092.2ms 1117ms
map-strings-typed.js (static) 906.8ms 949.4ms
nbody (3448ms, 2890ms) -16.2%
nbody hermes (CI) hermes (CI)
original/nbody.js 839.6ms 642.8ms
fully-typed/nbody.js 710ms 544.6ms
fully-typed/nbody.ts 865.2ms 648.8ms
original/nbody.js (static) 449.2ms 457.4ms
fully-typed/nbody.js (static) 135ms 134.4ms
fully-typed/nbody.ts (static) 449.2ms 462ms
string-switch (6503ms, 6380ms) -1.9%
string-switch (string-switch/plain) hermes (CI) hermes (CI)
bench.js 1316ms 1307.8ms
bench.js (static) 5187ms 5072.6ms
raytracer (5608ms, 5598ms) -0.2%
raytracer (raytracer/original) hermes (CI) hermes (CI)
bench-raytracer.js 1550.4ms 1448.8ms
raytracer.ts 1667.6ms 1554ms
bench-raytracer.js (static) 1198.4ms 1263.4ms
raytracer.ts (static) 1191.8ms 1331.6ms
MiniReact (30332ms, 29969ms) -1.2%
MiniReact hermes (CI) hermes (CI)
no-objects/out/simple-stripped.js 2239.2ms 2132.4ms
no-objects/out/simple-lowered.js 2270.8ms 2172.8ms
no-objects/out/music-stripped.js 42.6ms 43.2ms
no-objects/out/music-lowered.js 47.2ms 46.8ms
no-deps/stripped/MiniReact.js 5004ms 4735.4ms
no-deps/MiniReact.js 5256.2ms 4663.4ms
no-objects/out/simple.js 2260.4ms 2150.6ms
no-objects/out/music.js 45.6ms 45.4ms
no-objects/out/simple-stripped.js (static) 1725.2ms 1792.4ms
no-objects/out/simple-lowered.js (static) 1725.4ms 1832.8ms
no-objects/out/music-stripped.js (static) 18.8ms 20.2ms
no-objects/out/music-lowered.js (static) 19.4ms 23ms
no-deps/stripped/MiniReact.js (static) 4024.8ms 4251.4ms
no-deps/MiniReact.js (static) 3938.2ms 4220.8ms
no-objects/out/simple.js (static) 1695.2ms 1817.8ms
no-objects/out/music.js (static) 19ms 20.8ms
widgets (12934ms, 12871ms) -0.5%
widgets hermes (CI) hermes (CI)
simple-classes/widgets.js 1758.2ms 1616.2ms
original/es5/widgets.js 2798.8ms 2740.4ms
single-file/es5/widgets.js 2775.2ms 2729.8ms
simple-classes/widgets.js (static) 1012ms 1052.8ms
original/es5/widgets.js (static) 2283.2ms 2362.4ms
single-file/es5/widgets.js (static) 2306.2ms 2369.8ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants