Skip to content

Convert builds to use musl libc for generic linux support - #116

Open
Ben Lewis (ben-zen) wants to merge 5 commits into
microsoft:masterfrom
ben-zen:musl
Open

Convert builds to use musl libc for generic linux support#116
Ben Lewis (ben-zen) wants to merge 5 commits into
microsoft:masterfrom
ben-zen:musl

Conversation

@ben-zen

Copy link
Copy Markdown

ntttcp is a small utility that can be readily used on any linux box, but with its current libc linkage it's intimately tied to the machine it's compiled on. Switching to musl, statically linked, means that the binary the CI toolchain produces is usable on any Linux machine with a halfway-recent kernel, even going back to 2.6.

This enables a lightweight, universally applicable release, and can address #96

@lokeshmuthuraj

Copy link
Copy Markdown
Contributor

lubaihua33 / Simon Xiao (@simonxiaoss) Can you please review this PR?

I have reviewed the PR and the changes looks good.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. I have 2 minor suggestions:

  • Update README.md with note that CI builds now produce binaries usable across generic Linux distros.
  • Update TOOL_VERSION in src/const.h file from 1.4.7 to 1.4.8 since there is a change to binary build process and users must be able to distinguish old build and the new build in case of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants